Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make avatar lookup occur at image request #10540

Merged
merged 17 commits into from
Mar 27, 2020
Merged

make avatar lookup occur at image request #10540

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
c185a23
make avatar lookup occur at image request
zeripath Feb 28, 2020
bdcf287
Protect against evil email address ".."
zeripath Feb 29, 2020
9914e80
Fix tests
zeripath Feb 29, 2020
933320f
fix tests again
zeripath Feb 29, 2020
7609009
Obfuscate the email address in base64
zeripath Feb 29, 2020
58593d4
hash the complete email address
zeripath Mar 5, 2020
b4d479f
Merge branch 'master' into make-avatar-lookup-image
zeripath Mar 5, 2020
57339c0
Move to use a (potentially cached) db entry for emails
zeripath Mar 7, 2020
c6cca50
As per @lafriks and @guillep2k
zeripath Mar 8, 2020
08cf870
fix unit-tests
zeripath Mar 8, 2020
1e6efeb
Update models/avatar.go
zeripath Mar 8, 2020
2945e0b
Merge branch 'master' into make-avatar-lookup-image
zeripath Mar 9, 2020
d32222b
Merge branch 'master' into make-avatar-lookup-image
zeripath Mar 9, 2020
bb85931
Merge branch 'master' into make-avatar-lookup-image
zeripath Mar 22, 2020
c8fab76
Merge branch 'master' into make-avatar-lookup-image
zeripath Mar 26, 2020
4c09604
Merge branch 'master' into make-avatar-lookup-image
zeripath Mar 27, 2020
b5365ba
Add migration to create the EmailHash table
zeripath Mar 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix tests again
  • Loading branch information
@zeripath
zeripath committed Feb 29, 2020
commit 933320fa2997b108dff0356e37851995a149d75f
3 changes: 2 additions & 1 deletion modules/repository/commits_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ package repository

import (
"container/list"
"net/url"
"testing"
"time"

Expand Down Expand Up @@ -114,7 +115,7 @@ func TestPushCommits_AvatarLink(t *testing.T) {
pushCommits.AvatarLink("[email protected]"))

assert.Equal(t,
"https://secure.gravatar.com/avatar/19ade630b94e1e0535b3df7387434154?d=identicon",
"/avatar/email-"+url.PathEscape("nonexistent@example.com"),
pushCommits.AvatarLink("[email protected]"))
}

Expand Down