Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Price out of market message iteration. #1320

Closed
wants to merge 27 commits into from
Closed

Price out of market message iteration. #1320

wants to merge 27 commits into from

Conversation

fairlighteth
Copy link
Contributor

Summary

Screen Shot 2021-08-26 at 11 54 37

Screen Shot 2021-08-26 at 11 54 25

Notes

  • When custom limit orders will be implemented, we probably need to re-factor the 'orders is unfillable' given those limit orders (with custom pricing) are almost always by definition out of market.

biocom and others added 25 commits August 18, 2021 15:35
Add limit price and valid to/filled date.
c10d80b
Add limit price and valid to/filled date.
c07c06b
Fixed type of getLimitPrice utils function
6294eb0
Execution price WIP.
ad86001
Styled file for cleanup.
e56f1cb
Styled file for cleanup.
daeba48
Fix grid on mobile (Safari).
55258ed
comment out getExecutedPrice
28e5ef0
Merge conflict.
d6b8afe
Expired order strike through.
6a7e6be
Unfillable faq link external.
9c83925
Pull/merge conflict.
ef56009
@anxolin
Price functions for Recent History (#1289)
45e4464 
* Add bignumber, so library matches our dex-js

* Add price utils

* Refactor transaction summary

* Change todo

* Rename variable to executionPrice.

* Delete comment

* Remove comments and improve doc

* Fix path and default value

* Add datatype for api additional data (#1290)

# Summary

Continues #1289, 

Augment the order datatype so we can have the executed volumes. 
Adds the datatype where we can save the API information

It also makes use of this data in the recent history. 

## Not included

Saving the actual data.

Co-authored-by: biocom <[email protected]>
Correction of buy/sell prices.
9850f40
Close walletModal on connection success
141d546
fix price format
0533d76
Clean console.log
cfe67c6
Clean console.log
2f6436a
Price invert fix.
dbe3d60
@alfetopito
Orders panel execution price (#1309)
e58cdcb 
* Fix decimals bug

* Moved additional info to BaseOrder, everything is serializable

* Added additional info to order fullfilment type

* Passing along additional info when fulfillig order

* Storing additional info on order obj

Co-authored-by: Leandro Boscariol <[email protected]>
Merge branch 'orders-panel-10' of gno.github.com:gnosis/cowswap into …
6bf065b 
…orders-panel-13
Style execution price.
0a2564b
Fix transaction style for longer digits.
7489836
Solve merge conflict.
bc156e3
Alert message iteration.
3fd583e
@fairlighteth fairlighteth requested review from a team August 26, 2021 09:58
@github-actions
Copy link
Contributor

  • 🔭 GP Swap: Gnosis Protocol v2 Swap UI

@W3stside
Copy link
Contributor

history seems messed up

@fairlighteth
Copy link
Contributor Author

@W3stside Screenshot? Details?

anxolin
anxolin approved these changes Aug 26, 2021
View reviewed changes
Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! thanks for iterating on this one. I think its much better.

@W3stside
Copy link
Contributor

@W3stside Screenshot? Details?

The git history mate

@fairlighteth
Copy link
Contributor Author

@W3stside Did a bunch of pull origin's. Anything odd I should look at/fix?

@alfetopito
Copy link
Contributor

@W3stside Did a bunch of pull origin's. Anything odd I should look at/fix?

I assume David is talking about the 27 commits in the PR
screenshot_2021-08-26_14-06-33

Git history look messy.

These are the relevant changes for this PR, right?
3fd583e
ca5fe74

Suggestion to fix the git history (this is what I do with my PRs)

  1. Create a temporary branch just in case you mess up: git checkout -b temp; git checkout -
  2. Reset state to the branch you want to merge the PR onto: git fetch; git reset --hard origin/orders-panel-1
  3. Cherry pick the changes: git cherry-pick 3fd583e1cda344fb31cf08f18cf1619fa8944172; git cherry pick ca5fe74c32560d4f461871113750396314804230
  4. Force push upstream: git push origin price-outmarket -f

If you mess up at any point, restore the temp branch: git reset --hard temp

@fairlighteth fairlighteth mentioned this pull request Aug 27, 2021
Merged
@fairlighteth
Copy link
Contributor Author

Closing as it is replaced by #1346

@fairlighteth
Copy link
Contributor Author

@alfetopito Thanks for checking! I now created a new PR which is merged. @W3stside not sure how I messed that up, but it did a bunch of git pull origin's on this. Would be good to learn how to prevent this for the future.

@alfetopito
Copy link
Contributor

@alfetopito Thanks for checking! I now created a new PR which is merged. @W3stside not sure how I messed that up, but it did a bunch of git pull origin's on this. Would be good to learn how to prevent this for the future.

Use pull + rebase instead of merge:

  • git pull origin <branch> --rebase -- for the original branch updates
  • git fetch; git rebase origin/develop -- for syncing with upstream base branch

W3stside pushed a commit that referenced this pull request Sep 8, 2021
@ianlapham @moodysalem
@JFrankfurt @moontools-hyperion @lint-action
Refactor with core (#33)
878fc9c 
* Update index.ts

* feature(service worker): add offline support (#1319)

* Revert "feature(service worker): add offline support (#1319)" (#1320)

This reverts commit 34dfb41.

* Revert "Revert "feature(service worker): add offline support (#1319)" (#1320)" (#1321)

This reverts commit db3328c.

* unregisters all installed service workers (#1322)

* fix: modals stealing focus across frames (#1326)

* improvement(lists): add BA SEC tokens to unsupported list  (#1327)

* show hidden search results by default

* update break styles

* optimize filter, use debounce on input

* increase debounce time

* add ba association list

* handle dismiss (#1328)

* split up sdk use between core and v2

* Fix code style issues with ESLint

* remove service worker

Co-authored-by: Moody Salem <[email protected]>
Co-authored-by: Jordan Frankfurt <[email protected]>
Co-authored-by: Hyperion <[email protected]>
Co-authored-by: Lint Action <[email protected]>
@W3stside W3stside deleted the price-outmarket branch December 16, 2021 10:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anxolin anxolin anxolin approved these changes

@elena-zh elena-zh elena-zh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fairlighteth @W3stside @alfetopito @anxolin @elena-zh