This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anxolin
force-pushed
the
price-functions
branch
from
August 19, 2021 16:11
04e2b15
to
370cd4c
Compare
|
alfetopito
reviewed
Aug 19, 2021
W3stside
reviewed
Aug 19, 2021
W3stside
reviewed
Aug 19, 2021
W3stside
reviewed
Aug 19, 2021
W3stside
reviewed
Aug 19, 2021
alfetopito
approved these changes
Aug 23, 2021
# Summary Continues #1289, Augment the order datatype so we can have the executed volumes. Adds the datatype where we can save the API information It also makes use of this data in the recent history. ## Not included Saving the actual data.
fairlighteth
approved these changes
Aug 24, 2021
fairlighteth
added a commit
that referenced
this pull request
Aug 25, 2021
* Add limit price and valid to/filled date. * Add limit price and valid to/filled date. * Fixed type of getLimitPrice utils function * Execution price WIP. * Styled file for cleanup. * Styled file for cleanup. * Fix grid on mobile (Safari). * comment out getExecutedPrice * Expired order strike through. * Unfillable faq link external. * Price functions for Recent History (#1289) * Add bignumber, so library matches our dex-js * Add price utils * Refactor transaction summary * Change todo * Rename variable to executionPrice. * Delete comment * Remove comments and improve doc * Fix path and default value * Add datatype for api additional data (#1290) # Summary Continues #1289, Augment the order datatype so we can have the executed volumes. Adds the datatype where we can save the API information It also makes use of this data in the recent history. ## Not included Saving the actual data. Co-authored-by: biocom <[email protected]> * Correction of buy/sell prices. * Close walletModal on connection success * Orders panel execution price (#1309) * Fix decimals bug * Moved additional info to BaseOrder, everything is serializable * Added additional info to order fullfilment type * Passing along additional info when fulfillig order * Storing additional info on order obj Co-authored-by: Leandro Boscariol <[email protected]> Co-authored-by: Leandro Boscariol <[email protected]> Co-authored-by: Anxo Rodriguez <[email protected]> Co-authored-by: Leandro Boscariol <[email protected]>
fairlighteth
added a commit
that referenced
this pull request
Aug 26, 2021
* Add limit price and valid to/filled date. * Add limit price and valid to/filled date. * Fixed type of getLimitPrice utils function * Execution price WIP. * Styled file for cleanup. * Styled file for cleanup. * Fix grid on mobile (Safari). * comment out getExecutedPrice * Expired order strike through. * Unfillable faq link external. * Price functions for Recent History (#1289) * Add bignumber, so library matches our dex-js * Add price utils * Refactor transaction summary * Change todo * Rename variable to executionPrice. * Delete comment * Remove comments and improve doc * Fix path and default value * Add datatype for api additional data (#1290) # Summary Continues #1289, Augment the order datatype so we can have the executed volumes. Adds the datatype where we can save the API information It also makes use of this data in the recent history. ## Not included Saving the actual data. Co-authored-by: biocom <[email protected]> * Correction of buy/sell prices. * Close walletModal on connection success * fix price format * Clean console.log * Clean console.log * Price invert fix. * Orders panel execution price (#1309) * Fix decimals bug * Moved additional info to BaseOrder, everything is serializable * Added additional info to order fullfilment type * Passing along additional info when fulfillig order * Storing additional info on order obj Co-authored-by: Leandro Boscariol <[email protected]> * Style execution price. * Fix transaction style for longer digits. Co-authored-by: Leandro Boscariol <[email protected]> Co-authored-by: Anxo Rodriguez <[email protected]> Co-authored-by: Leandro Boscariol <[email protected]>
nenadV91
pushed a commit
that referenced
this pull request
Aug 27, 2021
* Orders panel component. * Props update. * Open ordersPanel on click connected wallet. (#1203) * WIP - Orders panel part 3 (Add wallet + orders to the sidebar) (#1210) * Open ordersPanel on click connected wallet. * Orders in side bar WIP. * Fix issue types * Revert "Fix issue types" This reverts commit cb95c89. * Fix issue with types 2 * Account details inside orders sidebar. * Fix import. * Fix folder name. Co-authored-by: Anxo Rodriguez <[email protected]> * WIP - Orders panel part 4 (Re-style account details/activity/orders) (#1227) * Open ordersPanel on click connected wallet. * Orders in side bar WIP. * Fix issue types * Revert "Fix issue types" This reverts commit cb95c89. * Fix issue with types 2 * Account details inside orders sidebar. * Fix import. * Fix folder name. * Re-style of account details/activity. Co-authored-by: Anxo Rodriguez <[email protected]> * WIP - Orders panel part 5 (More styling and tweaking) (#1234) * Open ordersPanel on click connected wallet. * Orders in side bar WIP. * Fix issue types * Revert "Fix issue types" This reverts commit cb95c89. * Fix issue with types 2 * Account details inside orders sidebar. * Fix import. * Fix folder name. * Re-style of account details/activity. * Orders sidebar styling. * Orders sidebar styling. * Orders sidebar styling. * Orders sidebar styling. * Orders sidebar styling. * Transaction update. * Transaction update. Co-authored-by: Anxo Rodriguez <[email protected]> * WIP - Orders panel part 6 (Address feedback an wallet issues) (#1249) * Open ordersPanel on click connected wallet. * Orders in side bar WIP. * Fix issue types * Revert "Fix issue types" This reverts commit cb95c89. * Fix issue with types 2 * Account details inside orders sidebar. * Fix import. * Fix folder name. * Re-style of account details/activity. * Orders sidebar styling. * Orders sidebar styling. * Orders sidebar styling. * Orders sidebar styling. * Orders sidebar styling. * Transaction update. * Transaction update. * Fix wallet stuff. * Fix wallet stuff. * Mobile tx detail indent. * WIP - Orders panel part 7 (TBD) (#1250) * tablet size fix * Fix 1238 Co-authored-by: Anxo Rodriguez <[email protected]> * Rename prop. * Orders Sidebar --> Slide in effect. (#1270) * Sidebar slide in. * Scroll fix. * Orders Sidebar --> Click to copy move. (#1269) * Click to copy move. * Icon wrapper remove. * Mobile header fixes. * Re-factor Copy component. * Cancelling label re-factor + Fix cancellation modal (#1293) * Cancelling label re-factor. * Fix close modal/sidebar click event. * Shimmer effect OPEN orders. * closeOrdersPanel for FAQ link. * Refert passing prop, instead open link new tab. * Update src/custom/components/AccountDetails/Transaction.tsx Co-authored-by: David <[email protected]> Co-authored-by: David <[email protected]> * Orders Sidebar --> Show limit prices + valid to/filled on dates (#1279) * Add limit price and valid to/filled date. * Add limit price and valid to/filled date. * Fixed type of getLimitPrice utils function * Execution price WIP. * Styled file for cleanup. * Styled file for cleanup. * Fix grid on mobile (Safari). * comment out getExecutedPrice * Expired order strike through. * Unfillable faq link external. * Price functions for Recent History (#1289) * Add bignumber, so library matches our dex-js * Add price utils * Refactor transaction summary * Change todo * Rename variable to executionPrice. * Delete comment * Remove comments and improve doc * Fix path and default value * Add datatype for api additional data (#1290) # Summary Continues #1289, Augment the order datatype so we can have the executed volumes. Adds the datatype where we can save the API information It also makes use of this data in the recent history. ## Not included Saving the actual data. Co-authored-by: biocom <[email protected]> * Correction of buy/sell prices. * Close walletModal on connection success * Orders panel execution price (#1309) * Fix decimals bug * Moved additional info to BaseOrder, everything is serializable * Added additional info to order fullfilment type * Passing along additional info when fulfillig order * Storing additional info on order obj Co-authored-by: Leandro Boscariol <[email protected]> Co-authored-by: Leandro Boscariol <[email protected]> Co-authored-by: Anxo Rodriguez <[email protected]> Co-authored-by: Leandro Boscariol <[email protected]> * Fix price format (#1310) * Add limit price and valid to/filled date. * Add limit price and valid to/filled date. * Fixed type of getLimitPrice utils function * Execution price WIP. * Styled file for cleanup. * Styled file for cleanup. * Fix grid on mobile (Safari). * comment out getExecutedPrice * Expired order strike through. * Unfillable faq link external. * Price functions for Recent History (#1289) * Add bignumber, so library matches our dex-js * Add price utils * Refactor transaction summary * Change todo * Rename variable to executionPrice. * Delete comment * Remove comments and improve doc * Fix path and default value * Add datatype for api additional data (#1290) # Summary Continues #1289, Augment the order datatype so we can have the executed volumes. Adds the datatype where we can save the API information It also makes use of this data in the recent history. ## Not included Saving the actual data. Co-authored-by: biocom <[email protected]> * Correction of buy/sell prices. * Close walletModal on connection success * fix price format * Clean console.log * Clean console.log * Price invert fix. * Orders panel execution price (#1309) * Fix decimals bug * Moved additional info to BaseOrder, everything is serializable * Added additional info to order fullfilment type * Passing along additional info when fulfillig order * Storing additional info on order obj Co-authored-by: Leandro Boscariol <[email protected]> * Style execution price. * Fix transaction style for longer digits. Co-authored-by: Leandro Boscariol <[email protected]> Co-authored-by: Anxo Rodriguez <[email protected]> Co-authored-by: Leandro Boscariol <[email protected]> * Price out of market iteration 2. (#1346) * Fix Safari sidebar style issue. Co-authored-by: Anxo Rodriguez <[email protected]> Co-authored-by: David <[email protected]> Co-authored-by: Leandro Boscariol <[email protected]> Co-authored-by: Leandro Boscariol <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Attempt to fix type issues related to the price functions.
This PR:
invert
support: The code is very similar to what we do in the explorer. It has now a TODO for when we have the SDK. Ideally, we wouldn't need to implement these in the projects and using the SDK would be enough.ActivitySummary
(side pannel) : The execution price is only displayed for full-filled orders.ActivitySummary
: Just some small code changes to reduce repetition.Additionally, it adds the dependency with
bignumber
so it matches with the one in dex-js (so there's no type issues).What is not included
FULLFILLED
, however, afait we don't update the order with the new executed amounts. We would need to review how to get this info, and consume it her. Note i left a TODO with a hardcoded price1.234567890
for all executed ordersfalse
in theinverted
param. But we should use internal state and allow the user to toggle that.