Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Error page improvements on iOS, FF+Win10 #1328

Closed
alongoni opened this issue Aug 26, 2021 · 4 comments
Closed

Error page improvements on iOS, FF+Win10 #1328

alongoni opened this issue Aug 26, 2021 · 4 comments
Assignees
@maria-vslvn @fapesteguia
Labels
Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system Mobile Affects mobile only Protofire Handled by Protofire development team

Comments

@alongoni
Copy link
Contributor

alongoni commented Aug 26, 2021 •
edited by elena-zh
Loading

Description
Reported in #1259
How to Reproduce
Steps to reproduce the behavior:

  1. Force an error by adding e.g:
    src/custom/pages/CowGame/index.tsx
    inside CowGame function:
    if (0 === 0) { throw new Error('This cow is dropping some serious milk 🥛!!') }

Open the error page in iOS:
Expected: there is no padding in the error log section from the right. And it was removed from the left: as a result, section value is not fully visible in an iPhone device (Android looks good):
image
@alongoni alongoni added Epic Protofire Handled by Protofire development team Enhancement New feature or request Low Severity indicator for defects. It won't cause any major break-down of the system Bug Something isn't working Mobile Affects mobile only and removed Epic labels Aug 26, 2021
@alongoni alongoni changed the title Hard errror on iOS Error page improvements on iOS Aug 26, 2021
@elena-zh elena-zh removed the Enhancement New feature or request label Aug 26, 2021
W3stside pushed a commit that referenced this issue Sep 8, 2021
@ianlapham
handle dismiss (#1328)
9170af8
W3stside pushed a commit that referenced this issue Sep 8, 2021
@ianlapham @moodysalem
@JFrankfurt @moontools-hyperion @lint-action
Refactor with core (#33)
878fc9c 
* Update index.ts

* feature(service worker): add offline support (#1319)

* Revert "feature(service worker): add offline support (#1319)" (#1320)

This reverts commit 34dfb41.

* Revert "Revert "feature(service worker): add offline support (#1319)" (#1320)" (#1321)

This reverts commit db3328c.

* unregisters all installed service workers (#1322)

* fix: modals stealing focus across frames (#1326)

* improvement(lists): add BA SEC tokens to unsupported list  (#1327)

* show hidden search results by default

* update break styles

* optimize filter, use debounce on input

* increase debounce time

* add ba association list

* handle dismiss (#1328)

* split up sdk use between core and v2

* Fix code style issues with ESLint

* remove service worker

Co-authored-by: Moody Salem <[email protected]>
Co-authored-by: Jordan Frankfurt <[email protected]>
Co-authored-by: Hyperion <[email protected]>
Co-authored-by: Lint Action <[email protected]>
@elena-zh
Copy link

just a note: the issue is also reproducible in Firefox + Win 10
image

@elena-zh elena-zh changed the title Error page improvements on iOS Error page improvements on iOS, FF+Win10 Sep 22, 2021
@maria-vslvn
Copy link
Contributor

maria-vslvn commented Oct 2, 2021 •
edited
Loading

@alfetopito @alongoni @elena-zh it’s more logics issue than css. but i could also help with css, not such flexible way as playing with error formatting, but i could do something like this:Снимок экрана 2021-10-01 в 18.33.56.png

@alfetopito
Copy link
Contributor

I wouldn't worry too much about this issue to be honest.

First, this is not supposed to be seen often 🤞
Second, users seeing this wouldn't benefit much from a nicely padded error display. As long as the reporting works, user's shouldn't care about the error.

@alongoni
Copy link
Contributor Author

Can we close this issue?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@maria-vslvn maria-vslvn

@fapesteguia fapesteguia

Labels
Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system Mobile Affects mobile only Protofire Handled by Protofire development team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@alfetopito @alongoni @maria-vslvn @fapesteguia @elena-zh