Minor Release v1.1.1 #406
Merged
Minor Release v1.1.1 #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- All conversions to CSR (except CSR to CSR) now conserve the original strategy (test for that are included) - CSR strategies now try to copy the least amount of data - Add exception throwing in case the load_balance would not work properly (when srow is empty)
- Make strategy helper variables const to ensure they do not change - Fix Hybrid read function
- GKO_NOT_SUPPORTED is the only macro that does not include the `throw`. This was not only a problem in this code, but also in unrelated code, which is also fixed within this commit - An Empty Dense matrix can now be converted to a CSR matrix - Moved the `GKO_NOT_SUPPORTED` to the cuda kernel, so empty matrices do not throw when applying a strategy.
- Change a `static_cast` in the strategies to a constructor call - Move empty matrix test from CSR to Dense (and add a move test)
tcojean
requested review from
upsj,
pratikvn,
thoasm,
yhmtsai and
hartwiganzt
upsj
previously approved these changes
Nov 27, 2019
`update_ginkgo_header.sh` now no longer returns a non-zero exit code, meaning it should no longer stop the `make` process when something goes wrong or is not found. Additionally, the script is now only called if `GINKGO_DEVEL_TOOLS` are enabled since non-developer would not benefit or need it.
- Add additional tests for access privileges - Add `rm` parameter
Changed `rm` parameter to `-f` in order to have a wider OS support.
tcojean
force-pushed
the
release/v1.1.1
branch
2 times, most recently
from
7a8bc8e
to
f881435
Compare
|
@yhmtsai these should be fixed. There is also a |
tcojean
force-pushed
the
release/v1.1.1
branch
from
f881435
to
56f4f16
Compare
|
@yhmtsai, can you check whether compilation still works on windows? Thanks |
|
@tcojean Sure, I can test it. |
tcojean
force-pushed
the
release/v1.1.1
branch
from
56f4f16
to
2471435
Compare
tcojean
force-pushed
the
release/v1.1.1
branch
from
2471435
to
72c84bc
Compare
|
I just realized that we say in the tutorial that it is a 2D Poisson solver, whereas it is actually a 1D Poisson solver. We can just remove the 2D and just call it a Poisson solver. So, I think we should update the following:
Any other places ? |
tcojean
force-pushed
the
release/v1.1.1
branch
from
72c84bc
to
67927d2
Compare
tcojean
force-pushed
the
release/v1.1.1
branch
from
67927d2
to
7fd7448
Compare
yhmtsai
previously approved these changes
Nov 29, 2019
tcojean
force-pushed
the
release/v1.1.1
branch
from
7fd7448
to
c8ec186
Compare
|
Reviews got dismissed again? Sorry about that, I guess I need to find a better way to generate documentation for the release branches. |
upsj
approved these changes
Dec 2, 2019
yhmtsai
approved these changes
Dec 2, 2019
tcojean
added a commit
that referenced
this pull request
Dec 3, 2019
Minor release v1.1.1 This version of Ginkgo provides a few fixes in Ginkgo's core routines. The supported systems and requirements are unchanged from version 1.1.0. ### Fixes + Fix the `test_install` step with `HIP` ([#409](#409)), + Improve Ginkgo's installation and fix the `test_install` step ([#406](#406)), + Fix some documentation issues ([#406](#406)), + Fix multiple code issues reported by sonarqube ([#406](#406)), + Update the git-cmake-format repository ([#399](#399)), + Improve the global update header script ([#390](#390)), + Fix broken bounds checks ([#388](#388)), + Fix CSR strategies and improve performance ([#379](#379)), + Fix a small typo in the stencil examples ([#381](#381)), + Fix ELL error on small matrices ([#375](#375)), + Fix SellP read function ([#374](#374)), + Add factorization support in `create_new_algorithm.sh` ([#371](#371))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
CHANGELOG
This version of Ginkgo provides a few fixes in Ginkgo's core routines. The
supported systems and requirements are unchanged from version 1.1.0.
Fixes
test_installstep (#406),create_new_algorithm.sh(#371).