Fix broken bounds checks #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upsj
added
is:bug
tcojean
reviewed
Nov 18, 2019
|
@upsj I forgot to point you towards the How to merge entry in our wiki. |
tcojean
added
1:ST:ready-to-merge
|
Some tests are failing due to changing to |
|
There were two types of failures: Mismatching exception types as @tcojean mentioned and some bounds checks indeed need to use |
tcojean
approved these changes
Nov 19, 2019
tcojean
added
1:ST:ready-to-merge
upsj
force-pushed
the
fix_bounds_checks
branch
from
94c3c7a
to
d508489
Compare
pratikvn
approved these changes
Nov 19, 2019
| @@ -240,9 +240,7 @@ class SparsityCsr | |||
| auto tmp = Array<value_type>{exec->get_master(), 1}; | |||
| tmp.get_data()[0] = value; | |||
| value_ = Array<value_type>{exec, std::move(tmp)}; | |||
| GKO_ENSURE_IN_BOUNDS(col_idxs_.get_num_elems() - 1, | |||
tcojean
added a commit
that referenced
this pull request
Dec 2, 2019
This version of Ginkgo provides a few fixes in Ginkgo's core routines. The supported systems and requirements are unchanged from version 1.1.0. ### Fixes + Improve Ginkgo's installation and fix the `test_install` step ([#406](#406)), + Fix some documentation issues ([#406](#406)), + Fix multiple code issues reported by sonarqube ([#406](#406)), + Update the git-cmake-format repository ([#399](#399)), + Improve the global update header script ([#390](#390)), + Fix broken bounds checks ([#388](#388)), + Fix CSR strategies and improve performance ([#379](#379)), + Fix a small typo in the stencil examples ([#381](#381)), + Fix ELL error on small matrices ([#375](#375)), + Fix SellP read function ([#374](#374)), + Add factorization support in `create_new_algorithm.sh` ([#371](#371)).
tcojean
added a commit
that referenced
this pull request
Dec 3, 2019
Minor release v1.1.1 This version of Ginkgo provides a few fixes in Ginkgo's core routines. The supported systems and requirements are unchanged from version 1.1.0. ### Fixes + Fix the `test_install` step with `HIP` ([#409](#409)), + Improve Ginkgo's installation and fix the `test_install` step ([#406](#406)), + Fix some documentation issues ([#406](#406)), + Fix multiple code issues reported by sonarqube ([#406](#406)), + Update the git-cmake-format repository ([#399](#399)), + Improve the global update header script ([#390](#390)), + Fix broken bounds checks ([#388](#388)), + Fix CSR strategies and improve performance ([#379](#379)), + Fix a small typo in the stencil examples ([#381](#381)), + Fix ELL error on small matrices ([#375](#375)), + Fix SellP read function ([#374](#374)), + Add factorization support in `create_new_algorithm.sh` ([#371](#371))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As #387 explains, we have some bounds checks that should rather be checks for equality, unless we want to allow our
Arrays to over-allocate memory, e.g. for SIMD purposes or similar.This pull request replaces all
GKO_ENSURE_IN_BOUNDSby equivalent or more strictGKO_ASSERT_EQ