Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update git-cmake-format source repository #399

Merged
merged 1 commit into from
Nov 25, 2019
Merged

Conversation

upsj
Copy link
Member

@upsj upsj commented Nov 25, 2019

We need to make some changes to the git-cmake-format.py script, so we forked the repository and need to update the corresponding paths and commit hash.

The changes are

  • Add .hpp.inc files to the list of formatted files
  • Don't unstage files when they need to be formatted. This is especially annoying when you only staged some of your files or even only parts of these files (git add -p). The behavior of the pre-commit hook should not change, since it only checks the staged files (without unstaged changes!) for formatting purposes.

@upsj upsj added the 1:ST:ready-for-review This PR is ready for review label Nov 25, 2019
Copy link
Member

@thoasm thoasm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@yhmtsai yhmtsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@upsj upsj added 1:ST:ready-to-merge This PR is ready to merge. and removed 1:ST:ready-for-review This PR is ready for review labels Nov 25, 2019
Copy link
Member

@pratikvn pratikvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@upsj upsj merged commit 273445e into develop Nov 25, 2019
@tcojean tcojean deleted the update_git_cmake_format branch November 27, 2019 11:26
@tcojean tcojean mentioned this pull request Nov 27, 2019
4 tasks
tcojean added a commit that referenced this pull request Dec 2, 2019
This version of Ginkgo provides a few fixes in Ginkgo's core routines. The
supported systems and requirements are unchanged from version 1.1.0.

### Fixes
+ Improve Ginkgo's installation and fix the `test_install` step ([#406](#406)),
+ Fix some documentation issues ([#406](#406)),
+ Fix multiple code issues reported by sonarqube ([#406](#406)),
+ Update the git-cmake-format repository ([#399](#399)),
+ Improve the global update header script ([#390](#390)),
+ Fix broken bounds checks ([#388](#388)),
+ Fix CSR strategies and improve performance ([#379](#379)),
+ Fix a small typo in the stencil examples ([#381](#381)),
+ Fix ELL error on small matrices ([#375](#375)),
+ Fix SellP read function ([#374](#374)),
+ Add factorization support in `create_new_algorithm.sh`  ([#371](#371)).
tcojean added a commit that referenced this pull request Dec 3, 2019
Minor release v1.1.1

This version of Ginkgo provides a few fixes in Ginkgo's core routines. The
supported systems and requirements are unchanged from version 1.1.0.

### Fixes
+ Fix the `test_install` step with `HIP` ([#409](#409)),
+ Improve Ginkgo's installation and fix the `test_install` step ([#406](#406)),
+ Fix some documentation issues ([#406](#406)),
+ Fix multiple code issues reported by sonarqube ([#406](#406)),
+ Update the git-cmake-format repository ([#399](#399)),
+ Improve the global update header script ([#390](#390)),
+ Fix broken bounds checks ([#388](#388)),
+ Fix CSR strategies and improve performance ([#379](#379)),
+ Fix a small typo in the stencil examples ([#381](#381)),
+ Fix ELL error on small matrices ([#375](#375)),
+ Fix SellP read function ([#374](#374)),
+ Add factorization support in `create_new_algorithm.sh`  ([#371](#371))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1:ST:ready-to-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants