Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: coinmarketcap widget dropdown not clickable #3591

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

henry40408
Copy link
Contributor

Proposed change

Fix drop-down of CoinMarketCap widget:

Screen Shot 2024-06-05 at 15 29 53-1

Currently, the drop-down is not clickable because its z-index is set to auto, while the title bar (.service-name) of the widget has a z-index of 10 (z-10). As a result, the drop-down is shadowed by the title bar. This pull request sets the z-index of the drop-down to 20 (z-20), the next higher z-index class name I found in TailwindCSS, making the drop-down clickable again.

Type of change

  • New service widget
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation only
  • Other (please explain)

Checklist:

[nix-shell:~/Develop/homepage]$ date; npm run lint
Wed Jun  5 15:40:21 CST 2024
                                                                                                                                                                                                                    
> [email protected] lint
> next lint
                                                                                                                                                                                                                    
✔ No ESLint warnings or errors
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

Tested on Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:126.0) Gecko/20100101 Firefox/126.0

Desktop Tablet Phone
Screen Shot 2024-06-05 at 15 42 41 Screen Shot 2024-06-05 at 15 44 16 Screen Shot 2024-06-05 at 15 46 08

@shamoon shamoon changed the title Fix dropdown of coinmarketcap widget Fix: coinmarketcap widget dropdown not clickable Jun 5, 2024
@shamoon shamoon enabled auto-merge (squash) June 5, 2024 07:55
@shamoon shamoon merged commit 36e77e1 into gethomepage:main Jun 5, 2024
2 checks passed
truecharts-admin added a commit to truecharts/charts that referenced this pull request Jun 6, 2024
…0.9.2@5356c97 by renovate (#22920)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[ghcr.io/gethomepage/homepage](https://togithub.com/gethomepage/homepage)
| patch | `v0.9.1` -> `v0.9.2` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>gethomepage/homepage (ghcr.io/gethomepage/homepage)</summary>

###
[`v0.9.2`](https://togithub.com/gethomepage/homepage/releases/tag/v0.9.2)

[Compare
Source](https://togithub.com/gethomepage/homepage/compare/v0.9.1...v0.9.2)

#### What's Changed

#### Security

- This release addresses a vulnerability that could allow leakage of API
keys from weather widgets, see
https://github.com/gethomepage/homepage/security/advisories/GHSA-cjgf-vhj6-8cx4
. Thanks to Kwstubbs for reporting.

#### App changes

- Fix: caddy widget broken in v0.9.1 by
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3579
- Fix: omada widget broken in v0.9.1 by
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3587
- Fix/handle null id in json rpc responses and cpu load representation
for openwrt widget by [@&#8203;LiranV](https://togithub.com/LiranV) in
[gethomepage/homepage#3576
- Fix: wg-easy threshold not properly computed by
[@&#8203;ConnerWithAnE](https://togithub.com/ConnerWithAnE) in
[gethomepage/homepage#3574
- Enhancement: support multiple instance annotation for Kubernetes
Automatic Service Discovery by
[@&#8203;aldycool](https://togithub.com/aldycool) in
[gethomepage/homepage#3590
- Fix: coinmarketcap widget dropdown not clickable by
[@&#8203;henry40408](https://togithub.com/henry40408) in
[gethomepage/homepage#3591

#### New Contributors

- [@&#8203;LiranV](https://togithub.com/LiranV) made their first
contribution in
[gethomepage/homepage#3576
- [@&#8203;aldycool](https://togithub.com/aldycool) made their first
contribution in
[gethomepage/homepage#3590

**Full Changelog**:
gethomepage/homepage@v0.9.1...v0.9.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zOTIuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM5Mi4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbImF1dG9tZXJnZSIsInVwZGF0ZS9kb2NrZXIvZ2VuZXJhbC9ub24tbWFqb3IiXX0=-->
szinn pushed a commit to szinn/k8s-homelab that referenced this pull request Jun 6, 2024
…v0.9.2 ) (#3790)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[ghcr.io/gethomepage/homepage](https://togithub.com/gethomepage/homepage)
| patch | `v0.9.1` -> `v0.9.2` |

---

### Release Notes

<details>
<summary>gethomepage/homepage (ghcr.io/gethomepage/homepage)</summary>

###
[`v0.9.2`](https://togithub.com/gethomepage/homepage/releases/tag/v0.9.2)

[Compare
Source](https://togithub.com/gethomepage/homepage/compare/v0.9.1...v0.9.2)

#### What's Changed

#### Security

- This release addresses a vulnerability that could allow leakage of API
keys from weather widgets, see
https://github.com/gethomepage/homepage/security/advisories/GHSA-cjgf-vhj6-8cx4
. Thanks to Kwstubbs for reporting.

#### App changes

- Fix: caddy widget broken in v0.9.1 by
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3579
- Fix: omada widget broken in v0.9.1 by
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3587
- Fix/handle null id in json rpc responses and cpu load representation
for openwrt widget by [@&#8203;LiranV](https://togithub.com/LiranV) in
[gethomepage/homepage#3576
- Fix: wg-easy threshold not properly computed by
[@&#8203;ConnerWithAnE](https://togithub.com/ConnerWithAnE) in
[gethomepage/homepage#3574
- Enhancement: support multiple instance annotation for Kubernetes
Automatic Service Discovery by
[@&#8203;aldycool](https://togithub.com/aldycool) in
[gethomepage/homepage#3590
- Fix: coinmarketcap widget dropdown not clickable by
[@&#8203;henry40408](https://togithub.com/henry40408) in
[gethomepage/homepage#3591

#### New Contributors

- [@&#8203;LiranV](https://togithub.com/LiranV) made their first
contribution in
[gethomepage/homepage#3576
- [@&#8203;aldycool](https://togithub.com/aldycool) made their first
contribution in
[gethomepage/homepage#3590

**Full Changelog**:
gethomepage/homepage@v0.9.1...v0.9.2

</details>

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zOTMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM5My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9jb250YWluZXIiLCJ0eXBlL3BhdGNoIl19-->

Co-authored-by: repo-jeeves[bot] <106431701+repo-jeeves[bot]@users.noreply.github.com>
spiceratops added a commit to spiceratops/k8s-gitops that referenced this pull request Jun 8, 2024
…785)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[ghcr.io/gethomepage/homepage](https://togithub.com/gethomepage/homepage)
| minor | `v0.8.13` -> `v0.9.2` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>gethomepage/homepage (ghcr.io/gethomepage/homepage)</summary>

###
[`v0.9.2`](https://togithub.com/gethomepage/homepage/releases/tag/v0.9.2)

[Compare
Source](https://togithub.com/gethomepage/homepage/compare/v0.9.1...v0.9.2)

#### What's Changed

#### Security

- This release addresses a vulnerability that could allow leakage of API
keys from weather widgets.

#### App changes

- Fix: caddy widget broken in v0.9.1 by
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3579
- Fix: omada widget broken in v0.9.1 by
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3587
- Fix/handle null id in json rpc responses and cpu load representation
for openwrt widget by [@&#8203;LiranV](https://togithub.com/LiranV) in
[gethomepage/homepage#3576
- Fix: wg-easy threshold not properly computed by
[@&#8203;ConnerWithAnE](https://togithub.com/ConnerWithAnE) in
[gethomepage/homepage#3574
- Enhancement: support multiple instance annotation for Kubernetes
Automatic Service Discovery by
[@&#8203;aldycool](https://togithub.com/aldycool) in
[gethomepage/homepage#3590
- Fix: coinmarketcap widget dropdown not clickable by
[@&#8203;henry40408](https://togithub.com/henry40408) in
[gethomepage/homepage#3591

#### New Contributors

- [@&#8203;LiranV](https://togithub.com/LiranV) made their first
contribution in
[gethomepage/homepage#3576
- [@&#8203;aldycool](https://togithub.com/aldycool) made their first
contribution in
[gethomepage/homepage#3590

**Full Changelog**:
gethomepage/homepage@v0.9.1...v0.9.2

###
[`v0.9.1`](https://togithub.com/gethomepage/homepage/releases/tag/v0.9.1)

[Compare
Source](https://togithub.com/gethomepage/homepage/compare/v0.8.13...v0.9.1)

#### What's Changed

*Note: version 0.9.0 contained a few issues and did not completely
resolve the security issue, it has been removed and all users are
recommended to upgrade to v0.9.1*

##### Security

- This version resolves security vulnerabilities discovered in some
integrations, see
GHSA-24m5-7vjx-9x37.
Thanks to kachakil-av for reporting.

##### Other Changes

- Fix: calendar integration broken in v0.9.0 by
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3565
- Fix: glances cpu metric broken in v0.9.0 by
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3566
- Fix: handle ghostfolio v2.79.0 breaking API changes by
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3471
- Fix: allow exclamation to open quicklaunch by
[@&#8203;jesusmlopezf](https://togithub.com/jesusmlopezf) in
[gethomepage/homepage#3475
- Feature: Wg-Easy Widget by
[@&#8203;ConnerWithAnE](https://togithub.com/ConnerWithAnE) and
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3476
- Change icon in the longhorn widget to use the same as resources by
[@&#8203;nick-disiere](https://togithub.com/nick-disiere) in
[gethomepage/homepage#3509
- Feature: SWAG dashboard widget by
[@&#8203;quietsy](https://togithub.com/quietsy) and
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3523
- Chore(deps): Bump crowdin/github-action from 1 to 2 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[gethomepage/homepage#3537
- Fix: remove comma in Caddy and EVCC widgets by
[@&#8203;grimsi](https://togithub.com/grimsi) in
[gethomepage/homepage#3551
- Enhancement: separate Internet search settings for quicklaunch by
[@&#8203;vycdev](https://togithub.com/vycdev) and
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3541
- Chore(deps-dev): Bump eslint-plugin-react from 7.34.1 to 7.34.2 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[gethomepage/homepage#3554
- Chore(deps-dev): Bump eslint-plugin-react-hooks from 4.6.0 to 4.6.2 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[gethomepage/homepage#3555

#### New Contributors

- [@&#8203;jesusmlopezf](https://togithub.com/jesusmlopezf) made their
first contribution in
[gethomepage/homepage#3475
- [@&#8203;ConnerWithAnE](https://togithub.com/ConnerWithAnE) made their
first contribution in
[gethomepage/homepage#3476
- [@&#8203;nick-disiere](https://togithub.com/nick-disiere) made their
first contribution in
[gethomepage/homepage#3509
- [@&#8203;quietsy](https://togithub.com/quietsy) made their first
contribution in
[gethomepage/homepage#3523
- [@&#8203;vycdev](https://togithub.com/vycdev) made their first
contribution in
[gethomepage/homepage#3541

**Full Changelog**:
gethomepage/homepage@v0.8.13...v0.9.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zODUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM5NC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9jb250YWluZXIiLCJ0eXBlL21pbm9yIl19-->
Copy link
Contributor

github-actions bot commented Jul 6, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns. See our contributing guidelines for more details.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants