Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: allow exclamation to open quicklaunch #3475

Merged
merged 2 commits into from
May 17, 2024
Merged

Fix: allow exclamation to open quicklaunch #3475

merged 2 commits into from
May 17, 2024

Conversation

jesusmlopezf
Copy link
Contributor

@jesusmlopezf jesusmlopezf commented May 16, 2024 •
edited
Loading

Proposed change

Quicklaunch wouldn't start with characters that require modifier keys to be typed (i.e. !,@,#,$), making it annoying to use quicklaunch alongside duckduckgo bangs

Type of change

  • New service widget
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation only
  • Other (please explain)

Checklist:

  • If applicable, I have added corresponding documentation changes.
  • If applicable, I have reviewed the feature and / or service widget guidelines.
  • I have checked that all code style checks pass using pre-commit hooks and linting checks.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

@shamoon
Copy link
Collaborator

shamoon commented May 16, 2024

Thanks. Are all of those characters necessary for the ddg shebang?

@shamoon shamoon enabled auto-merge (squash) May 16, 2024 19:36
@shamoon shamoon changed the title Match for special characters with modifier keys to open quicklaunch Fix: allow special characters with modifier keys to open quicklaunch May 16, 2024
@jesusmlopezf
Copy link
Contributor Author

No, but I figured people may want to use them in their custom providers

@shamoon
Copy link
Collaborator

shamoon commented May 16, 2024

Gotcha. If you wouldnt mind trimming it down, no one has requested this in the ~2y QL has been around so I dont think theres all that much need for it but the shebang is a valid use case

auto-merge was automatically disabled May 16, 2024 20:15

Head branch was pushed to by a user without write access

@jesusmlopezf
Copy link
Contributor Author

Limited to only the bang char (!)

@shamoon shamoon changed the title Fix: allow special characters with modifier keys to open quicklaunch Fix: allow shebang to open quicklaunch May 16, 2024
@shamoon shamoon changed the title Fix: allow shebang to open quicklaunch Fix: allow exclamation to open quicklaunch May 16, 2024
shamoon
shamoon approved these changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers thanks

@shamoon shamoon merged commit 1144f4d into gethomepage:main May 17, 2024
2 checks passed
truecharts-admin added a commit to truecharts/charts that referenced this pull request Jun 3, 2024
@truecharts-admin
chore(deps): update container image ghcr.io/gethomepage/homepage to v…
88cc34f 
…0.9.0@e0d26bb by renovate (#22802)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[ghcr.io/gethomepage/homepage](https://togithub.com/gethomepage/homepage)
| minor | `v0.8.13` -> `v0.9.0` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>gethomepage/homepage (ghcr.io/gethomepage/homepage)</summary>

###
[`v0.9.0`](https://togithub.com/gethomepage/homepage/releases/tag/v0.9.0)

[Compare
Source](https://togithub.com/gethomepage/homepage/compare/v0.8.13...v0.9.0)

#### What's Changed

##### Security

- This version resolves security vulnerabilities discovered in some
integrations, see
GHSA-24m5-7vjx-9x37.
Thanks to kachakil-av for reporting.

##### Other Changes

- Fix: handle ghostfolio v2.79.0 breaking API changes by
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3471
- Fix: allow exclamation to open quicklaunch by
[@&#8203;jesusmlopezf](https://togithub.com/jesusmlopezf) in
[gethomepage/homepage#3475
- Feature: Wg-Easy Widget by
[@&#8203;ConnerWithAnE](https://togithub.com/ConnerWithAnE) and
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3476
- Change icon in the longhorn widget to use the same as resources by
[@&#8203;nick-disiere](https://togithub.com/nick-disiere) in
[gethomepage/homepage#3509
- Feature: SWAG dashboard widget by
[@&#8203;quietsy](https://togithub.com/quietsy) and
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3523
- Chore(deps): Bump crowdin/github-action from 1 to 2 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[gethomepage/homepage#3537
- Fix: remove comma in Caddy and EVCC widgets by
[@&#8203;grimsi](https://togithub.com/grimsi) in
[gethomepage/homepage#3551
- Enhancement: separate Internet search settings for quicklaunch by
[@&#8203;vycdev](https://togithub.com/vycdev) and
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3541
- Chore(deps-dev): Bump eslint-plugin-react from 7.34.1 to 7.34.2 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[gethomepage/homepage#3554
- Chore(deps-dev): Bump eslint-plugin-react-hooks from 4.6.0 to 4.6.2 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[gethomepage/homepage#3555

#### New Contributors

- [@&#8203;jesusmlopezf](https://togithub.com/jesusmlopezf) made their
first contribution in
[gethomepage/homepage#3475
- [@&#8203;ConnerWithAnE](https://togithub.com/ConnerWithAnE) made their
first contribution in
[gethomepage/homepage#3476
- [@&#8203;nick-disiere](https://togithub.com/nick-disiere) made their
first contribution in
[gethomepage/homepage#3509
- [@&#8203;quietsy](https://togithub.com/quietsy) made their first
contribution in
[gethomepage/homepage#3523
- [@&#8203;vycdev](https://togithub.com/vycdev) made their first
contribution in
[gethomepage/homepage#3541

**Full Changelog**:
gethomepage/homepage@v0.8.13...v0.9.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zODUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM4NS4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbImF1dG9tZXJnZSIsInVwZGF0ZS9kb2NrZXIvZ2VuZXJhbC9ub24tbWFqb3IiXX0=-->
szinn pushed a commit to szinn/k8s-homelab that referenced this pull request Jun 3, 2024
@repo-jeeves
feat(container): update image ghcr.io/gethomepage/homepage ( v0.8.13 …
3cefdcd 
…→ v0.9.0 ) (#3772)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[ghcr.io/gethomepage/homepage](https://togithub.com/gethomepage/homepage)
| minor | `v0.8.13` -> `v0.9.0` |

---

### Release Notes

<details>
<summary>gethomepage/homepage (ghcr.io/gethomepage/homepage)</summary>

###
[`v0.9.0`](https://togithub.com/gethomepage/homepage/releases/tag/v0.9.0)

[Compare
Source](https://togithub.com/gethomepage/homepage/compare/v0.8.13...v0.9.0)

#### What's Changed

##### Security

- This version resolves security vulnerabilities discovered in some
integrations, see
GHSA-24m5-7vjx-9x37.
Thanks to kachakil-av for reporting.

##### Other Changes

- Fix: handle ghostfolio v2.79.0 breaking API changes by
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3471
- Fix: allow exclamation to open quicklaunch by
[@&#8203;jesusmlopezf](https://togithub.com/jesusmlopezf) in
[gethomepage/homepage#3475
- Feature: Wg-Easy Widget by
[@&#8203;ConnerWithAnE](https://togithub.com/ConnerWithAnE) and
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3476
- Change icon in the longhorn widget to use the same as resources by
[@&#8203;nick-disiere](https://togithub.com/nick-disiere) in
[gethomepage/homepage#3509
- Feature: SWAG dashboard widget by
[@&#8203;quietsy](https://togithub.com/quietsy) and
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3523
- Chore(deps): Bump crowdin/github-action from 1 to 2 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[gethomepage/homepage#3537
- Fix: remove comma in Caddy and EVCC widgets by
[@&#8203;grimsi](https://togithub.com/grimsi) in
[gethomepage/homepage#3551
- Enhancement: separate Internet search settings for quicklaunch by
[@&#8203;vycdev](https://togithub.com/vycdev) and
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3541
- Chore(deps-dev): Bump eslint-plugin-react from 7.34.1 to 7.34.2 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[gethomepage/homepage#3554
- Chore(deps-dev): Bump eslint-plugin-react-hooks from 4.6.0 to 4.6.2 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[gethomepage/homepage#3555

#### New Contributors

- [@&#8203;jesusmlopezf](https://togithub.com/jesusmlopezf) made their
first contribution in
[gethomepage/homepage#3475
- [@&#8203;ConnerWithAnE](https://togithub.com/ConnerWithAnE) made their
first contribution in
[gethomepage/homepage#3476
- [@&#8203;nick-disiere](https://togithub.com/nick-disiere) made their
first contribution in
[gethomepage/homepage#3509
- [@&#8203;quietsy](https://togithub.com/quietsy) made their first
contribution in
[gethomepage/homepage#3523
- [@&#8203;vycdev](https://togithub.com/vycdev) made their first
contribution in
[gethomepage/homepage#3541

**Full Changelog**:
gethomepage/homepage@v0.8.13...v0.9.0

</details>

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zODUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM4NS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9jb250YWluZXIiLCJ0eXBlL21pbm9yIl19-->

Co-authored-by: repo-jeeves[bot] <106431701+repo-jeeves[bot]@users.noreply.github.com>
szinn pushed a commit to szinn/k8s-homelab that referenced this pull request Jun 4, 2024
@repo-jeeves
fix(container): update image ghcr.io/gethomepage/homepage ( v0.9.0 → …
c432174 
…v0.9.1 ) (#3774)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[ghcr.io/gethomepage/homepage](https://togithub.com/gethomepage/homepage)
| patch | `v0.9.0` -> `v0.9.1` |

# Warnings (1)

Please correct - or verify that you can safely ignore - these warnings
before you merge this PR.

- `ghcr.io/gethomepage/homepage`: Could not determine new digest for
update (docker package ghcr.io/gethomepage/homepage)

---

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>gethomepage/homepage (ghcr.io/gethomepage/homepage)</summary>

###
[`v0.9.1`](https://togithub.com/gethomepage/homepage/releases/tag/v0.9.1)

[Compare
Source](https://togithub.com/gethomepage/homepage/compare/v0.8.13...v0.9.1)

#### What's Changed

*Note: version 0.9.0 contained a few issues and did not completely
resolve the security issue, it has been removed and all users are
recommended to upgrade to v0.9.1*

##### Security

- This version resolves security vulnerabilities discovered in some
integrations, see
GHSA-24m5-7vjx-9x37.
Thanks to kachakil-av for reporting.

##### Other Changes

- Fix: calendar integration broken in v0.9.0 by
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3565
- Fix: glances cpu metric broken in v0.9.0 by
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3566
- Fix: handle ghostfolio v2.79.0 breaking API changes by
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3471
- Fix: allow exclamation to open quicklaunch by
[@&#8203;jesusmlopezf](https://togithub.com/jesusmlopezf) in
[gethomepage/homepage#3475
- Feature: Wg-Easy Widget by
[@&#8203;ConnerWithAnE](https://togithub.com/ConnerWithAnE) and
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3476
- Change icon in the longhorn widget to use the same as resources by
[@&#8203;nick-disiere](https://togithub.com/nick-disiere) in
[gethomepage/homepage#3509
- Feature: SWAG dashboard widget by
[@&#8203;quietsy](https://togithub.com/quietsy) and
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3523
- Chore(deps): Bump crowdin/github-action from 1 to 2 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[gethomepage/homepage#3537
- Fix: remove comma in Caddy and EVCC widgets by
[@&#8203;grimsi](https://togithub.com/grimsi) in
[gethomepage/homepage#3551
- Enhancement: separate Internet search settings for quicklaunch by
[@&#8203;vycdev](https://togithub.com/vycdev) and
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3541
- Chore(deps-dev): Bump eslint-plugin-react from 7.34.1 to 7.34.2 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[gethomepage/homepage#3554
- Chore(deps-dev): Bump eslint-plugin-react-hooks from 4.6.0 to 4.6.2 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[gethomepage/homepage#3555

#### New Contributors

- [@&#8203;jesusmlopezf](https://togithub.com/jesusmlopezf) made their
first contribution in
[gethomepage/homepage#3475
- [@&#8203;ConnerWithAnE](https://togithub.com/ConnerWithAnE) made their
first contribution in
[gethomepage/homepage#3476
- [@&#8203;nick-disiere](https://togithub.com/nick-disiere) made their
first contribution in
[gethomepage/homepage#3509
- [@&#8203;quietsy](https://togithub.com/quietsy) made their first
contribution in
[gethomepage/homepage#3523
- [@&#8203;vycdev](https://togithub.com/vycdev) made their first
contribution in
[gethomepage/homepage#3541

**Full Changelog**:
gethomepage/homepage@v0.8.13...v0.9.1

</details>

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zODcuMyIsInVwZGF0ZWRJblZlciI6IjM3LjM4Ny4zIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9jb250YWluZXIiLCJ0eXBlL3BhdGNoIl19-->

Co-authored-by: repo-jeeves[bot] <106431701+repo-jeeves[bot]@users.noreply.github.com>
spiceratops added a commit to spiceratops/k8s-gitops that referenced this pull request Jun 8, 2024
@spiceratops
feat(container): update image ghcr.io/gethomepage/homepage to v0.9.2 (#…
d148097 
…785)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[ghcr.io/gethomepage/homepage](https://togithub.com/gethomepage/homepage)
| minor | `v0.8.13` -> `v0.9.2` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>gethomepage/homepage (ghcr.io/gethomepage/homepage)</summary>

###
[`v0.9.2`](https://togithub.com/gethomepage/homepage/releases/tag/v0.9.2)

[Compare
Source](https://togithub.com/gethomepage/homepage/compare/v0.9.1...v0.9.2)

#### What's Changed

#### Security

- This release addresses a vulnerability that could allow leakage of API
keys from weather widgets.

#### App changes

- Fix: caddy widget broken in v0.9.1 by
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3579
- Fix: omada widget broken in v0.9.1 by
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3587
- Fix/handle null id in json rpc responses and cpu load representation
for openwrt widget by [@&#8203;LiranV](https://togithub.com/LiranV) in
[gethomepage/homepage#3576
- Fix: wg-easy threshold not properly computed by
[@&#8203;ConnerWithAnE](https://togithub.com/ConnerWithAnE) in
[gethomepage/homepage#3574
- Enhancement: support multiple instance annotation for Kubernetes
Automatic Service Discovery by
[@&#8203;aldycool](https://togithub.com/aldycool) in
[gethomepage/homepage#3590
- Fix: coinmarketcap widget dropdown not clickable by
[@&#8203;henry40408](https://togithub.com/henry40408) in
[gethomepage/homepage#3591

#### New Contributors

- [@&#8203;LiranV](https://togithub.com/LiranV) made their first
contribution in
[gethomepage/homepage#3576
- [@&#8203;aldycool](https://togithub.com/aldycool) made their first
contribution in
[gethomepage/homepage#3590

**Full Changelog**:
gethomepage/homepage@v0.9.1...v0.9.2

###
[`v0.9.1`](https://togithub.com/gethomepage/homepage/releases/tag/v0.9.1)

[Compare
Source](https://togithub.com/gethomepage/homepage/compare/v0.8.13...v0.9.1)

#### What's Changed

*Note: version 0.9.0 contained a few issues and did not completely
resolve the security issue, it has been removed and all users are
recommended to upgrade to v0.9.1*

##### Security

- This version resolves security vulnerabilities discovered in some
integrations, see
GHSA-24m5-7vjx-9x37.
Thanks to kachakil-av for reporting.

##### Other Changes

- Fix: calendar integration broken in v0.9.0 by
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3565
- Fix: glances cpu metric broken in v0.9.0 by
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3566
- Fix: handle ghostfolio v2.79.0 breaking API changes by
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3471
- Fix: allow exclamation to open quicklaunch by
[@&#8203;jesusmlopezf](https://togithub.com/jesusmlopezf) in
[gethomepage/homepage#3475
- Feature: Wg-Easy Widget by
[@&#8203;ConnerWithAnE](https://togithub.com/ConnerWithAnE) and
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3476
- Change icon in the longhorn widget to use the same as resources by
[@&#8203;nick-disiere](https://togithub.com/nick-disiere) in
[gethomepage/homepage#3509
- Feature: SWAG dashboard widget by
[@&#8203;quietsy](https://togithub.com/quietsy) and
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3523
- Chore(deps): Bump crowdin/github-action from 1 to 2 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[gethomepage/homepage#3537
- Fix: remove comma in Caddy and EVCC widgets by
[@&#8203;grimsi](https://togithub.com/grimsi) in
[gethomepage/homepage#3551
- Enhancement: separate Internet search settings for quicklaunch by
[@&#8203;vycdev](https://togithub.com/vycdev) and
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3541
- Chore(deps-dev): Bump eslint-plugin-react from 7.34.1 to 7.34.2 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[gethomepage/homepage#3554
- Chore(deps-dev): Bump eslint-plugin-react-hooks from 4.6.0 to 4.6.2 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[gethomepage/homepage#3555

#### New Contributors

- [@&#8203;jesusmlopezf](https://togithub.com/jesusmlopezf) made their
first contribution in
[gethomepage/homepage#3475
- [@&#8203;ConnerWithAnE](https://togithub.com/ConnerWithAnE) made their
first contribution in
[gethomepage/homepage#3476
- [@&#8203;nick-disiere](https://togithub.com/nick-disiere) made their
first contribution in
[gethomepage/homepage#3509
- [@&#8203;quietsy](https://togithub.com/quietsy) made their first
contribution in
[gethomepage/homepage#3523
- [@&#8203;vycdev](https://togithub.com/vycdev) made their first
contribution in
[gethomepage/homepage#3541

**Full Changelog**:
gethomepage/homepage@v0.8.13...v0.9.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zODUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM5NC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9jb250YWluZXIiLCJ0eXBlL21pbm9yIl19-->
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns. See our contributing guidelines for more details.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shamoon shamoon shamoon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jesusmlopezf @shamoon