Enhancement: separate Internet search settings for quicklaunch

[vycdev]

Reopened the pull request as my post has reached 10 upvotes.

Proposed change

Separated quicklaunch's search provider dependency from the search widget settings
Closes #3247

• New service widget
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Documentation only
• Other (please explain)

The search engine setting for the quicklaunch component will no longer depend on the settings for the search widget.

Checklist:

• If applicable, I have added corresponding documentation changes.
• If applicable, I have reviewed the feature and / or service widget guidelines.
• I have checked that all code style checks pass using pre-commit hooks and linting checks.
• If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

[shamoon]

Im not really going to dig into this yet because this is unacceptable as-is because it amounts to a complete breaking change.

Simply put, users who have been using quick launch with their current search widget provider will upgrade and suddenly it wont work.

This needs to still support the current method of getting search provider from the widget. Probably best would be to revert most of this and just add support for the new provider setting to the quicklaunch settings.

[vycdev]

I've made the changes that were requested. Now if there is no provider set in the quick launch settings then it will fallback to the search widget provider. If neither are specified then the internet search will be disabled.

Likewise now showSearchSuggestions works as it did originally.

I also tested everything again.

Let me know if there is anything else that needs to be changed.

[shamoon]

Thanks