sdf 1.12: rename state subelements with _state suffix #1377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Peters <[email protected]>
Update some existing tests to verify conversion logic. Signed-off-by: Steve Peters <[email protected]>
The Converter currently only acts on the first child element it finds; it doesn't act on all sibling elements. I've added example SDFormat files and tests to illustrate the issue. Signed-off-by: Steve Peters <[email protected]>
7 tasks
8 tasks
|
as an alternative to the partial support for backwards compatibility in this pull request, I've opened a pull request in #1455 that renames the state subelements as a breaking change |
|
see #1455 instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Part of #632
Summary
There is some overlap in the names used for elements in the
//world/statespecification and elsewhere, for example the model_state.sdf file included in state.sdf defines an element named model. This has caused challenges with aliasing in XSD (see #632 and #643), and it would be simpler if some of these elements had different names (for example by appending a_statesuffix). This pull request is a work-in-progress to append this suffix to the relevant state tags in SDFormat 1.12 with automatic conversion of state elements defined in earlier versions of the spec. I have the conversion partially working, but have run into an issue with theConverterclass, which does not act on all sibling elements, but only to the first child element for a given<move>conversion.Test it
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.