Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sdf 1.12: rename state subelements with _state suffix #1377

Closed
wants to merge 3 commits into from
Closed

sdf 1.12: rename state subelements with _state suffix #1377

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
818b8f3
Spec 1.12: add _state suffix to state subelements
scpeters Feb 27, 2024
dd2054f
Rename state elements when converting to 1.12
scpeters Feb 27, 2024
e9de659
Add tests showing problems with conversion
scpeters Mar 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Next Next commit
Spec 1.12: add _state suffix to state subelements 
Signed-off-by: Steve Peters <[email protected]>
  • Loading branch information
@scpeters
scpeters committed Mar 1, 2024
commit 818b8f30df3d43a08b8183f410a8c190169f5656
2 changes: 1 addition & 1 deletion sdf/1.12/light_state.sdf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<!-- State information for a light -->
<element name="light" required="*">
<element name="light_state" required="*">
<description>Light state</description>

<attribute name="name" type="string" default="__default__" required="1">
Expand Down
4 changes: 2 additions & 2 deletions sdf/1.12/link_state.sdf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<!-- State information for a link -->
<element name="link" required="*">
<element name="link_state" required="*">
<description>Link state</description>

<attribute name="name" type="string" default="__default__" required="1">
Expand Down Expand Up @@ -27,7 +27,7 @@
</description>
</element>

<element name="collision" required="*">
<element name="collision_state" required="*">
<description>Collision state</description>

<attribute name="name" type="string" default="__default__" required="1">
Expand Down
6 changes: 3 additions & 3 deletions sdf/1.12/model_state.sdf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
<!-- State information for a model -->
<element name="model" required="*">
<element name="model_state" required="*">
<description>Model state</description>

<attribute name="name" type="string" default="__default__" required="1">
<description>Name of the model</description>
</attribute>

<element name="joint" required="*">
<element name="joint_state" required="*">
<description>Joint angle</description>

<attribute name="name" type="string" default="__default__" required="1">
Expand All @@ -22,7 +22,7 @@
</element>
</element>

<element name="model" ref="model_state" required="*">
<element name="model_state" ref="model_state" required="*">
<description>A nested model state element</description>
<attribute name="name" type="string" default="__default__" required="1">
<description>Name of the model. </description>
Expand Down