Reduce circular dependencies #5409
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smcv
force-pushed
the
split-utils
branch
2 times, most recently
from
803535e
to
de5d51e
Compare
Merged
|
I tried also splitting up |
The exports module doesn't actually need these, and this removes a circular dependency: previously, exports both depended on and was depended on by dir. Signed-off-by: Simon McVittie <[email protected]>
This allows us to break a circular dependency between utils and context. Signed-off-by: Simon McVittie <[email protected]>
Each of these is only needed in one place, so move them there. This is another step towards the utils module being the lowest-level. Signed-off-by: Simon McVittie <[email protected]>
smcv
changed the title
|
Merged as part of #5801. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The overall goal of this branch is to break up unmanageably large translation units, and make the common/ code more understandable by separating it into layers (utils < exports < context < ...) instead of having all modules call into all other modules. The version in this PR only partially achieves that, but it's a start.
exports: Remove unused headers
The exports module doesn't actually need these, and this removes a
circular dependency: previously, exports both depended on and was
depended on by dir.
common: Move flatpak_context_get_allowed_exports to FlatpakContext
This allows us to break a circular dependency between utils and context.
common: Don't depend on generated D-Bus code in utils module
Each of these is only needed in one place, so move them there. This is
another step towards the utils module being the lowest-level.