common: Move functions for dealing with AppStream XML to their own file #5801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The exports module doesn't actually need these, and this removes a circular dependency: previously, exports both depended on and was depended on by dir. Signed-off-by: Simon McVittie <[email protected]>
This allows us to break a circular dependency between utils and context. Signed-off-by: Simon McVittie <[email protected]>
Each of these is only needed in one place, so move them there. This is another step towards the utils module being the lowest-level. Signed-off-by: Simon McVittie <[email protected]>
This seems like an obvious set of functionality to be grouped together in service of the wider goal of making flatpak-utils smaller and more manageable. Signed-off-by: Simon McVittie <[email protected]>
Signed-off-by: Simon McVittie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #5409, with the same goals.
Reduce circular dependencies #5409
common: Move functions for dealing with AppStream XML to their own file
This seems like an obvious set of functionality to be grouped together
in service of the wider goal of making flatpak-utils smaller and more
manageable.
xml-utils: Don't expose symbols that don't need to be visble