utils: Refactoring #5416
Merged
utils: Refactoring #5416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation never actually moved to -ref-utils. Signed-off-by: Simon McVittie <[email protected]>
This will help to break circular dependencies between FlatpakExports and flatpak-run. Signed-off-by: Simon McVittie <[email protected]>
This matches where it was declared. Signed-off-by: Simon McVittie <[email protected]>
Signed-off-by: Simon McVittie <[email protected]>
utils-http is conceptually larger than utils. Signed-off-by: Simon McVittie <[email protected]>
Previously we were relying on flatpak-utils-private.h having a circular dependency on this, but I'm intending to remove that during future refactoring. Signed-off-by: Simon McVittie <[email protected]>
This cuts more circular dependencies between flatpak-run and flatpak-exports. Signed-off-by: Simon McVittie <[email protected]>
By giving the context a bit more knowledge of which directories Flatpak uses for what, we can stop it from depending on the dir/run modules, which themselves depend on FlatpakContext. Signed-off-by: Simon McVittie <[email protected]>
alexlarsson
force-pushed
the
refactor-utils
branch
from
39d296f
to
8175b9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various smaller refactors in preparation for #5409.
common: Move declaration of get_compat_arch_reverse back to -utils
The implementation never actually moved to -ref-utils.
common: Move flatpak_abs_usrmerged_dirs to FlatpakExports
This will help to break circular dependencies between FlatpakExports
and flatpak-run.
common: Move flatpak_is_app_runtime_or_appstream_ref to ref-utils
This matches where it was declared.
common: Remove unused functions
common: Stop including utils-http in utils
utils-http is conceptually larger than utils.
common: Explicitly include context's own header
Previously we were relying on flatpak-utils-private.h having a circular
dependency on this, but I'm intending to remove that during future
refactoring.
common: Move metadata to its own header
This cuts more circular dependencies between flatpak-run and
flatpak-exports.
common: Break circular dependency between context and dir/run
By giving the context a bit more knowledge of which directories Flatpak
uses for what, we can stop it from depending on the dir/run modules,
which themselves depend on FlatpakContext.