Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove strict mode config #823

Merged
merged 7 commits into from
May 10, 2024
Merged

Remove strict mode config #823

merged 7 commits into from
May 10, 2024

Conversation

fractalwrench
Copy link
Contributor

Goal

Removes the concept of 'strict mode' for internal error logging. In practice this has not been used & complicates the implementation, so we should remove it.

@fractalwrench fractalwrench requested a review from a team as a code owner May 9, 2024 10:42
Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 80.76923% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 81.51%. Comparing base (461946e) to head (e504e3f).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #823      +/-   ##
==========================================
+ Coverage   81.41%   81.51%   +0.10%     
==========================================
  Files         426      425       -1     
  Lines       11351    11358       +7     
  Branches     1687     1689       +2     
==========================================
+ Hits         9241     9259      +18     
+ Misses       1401     1390      -11     
  Partials      709      709              
Files Coverage Δ
...roid/embracesdk/config/behavior/SessionBehavior.kt 83.33% <ø> (+3.33%) ⬆️
...roid/embracesdk/config/local/SessionLocalConfig.kt 100.00% <100.00%> (ø)
...oid/embracesdk/injection/SdkObservabilityModule.kt 100.00% <100.00%> (ø)
.../embracesdk/logging/EmbraceInternalErrorService.kt 90.47% <100.00%> (ø)
...android/embracesdk/payload/LegacyExceptionError.kt 94.44% <100.00%> (-0.80%) ⬇️
...android/embracesdk/FlutterInternalInterfaceImpl.kt 91.66% <66.66%> (ø)
...e/android/embracesdk/UnityInternalInterfaceImpl.kt 45.28% <50.00%> (ø)
...ndroid/embracesdk/capture/aei/AeiDataSourceImpl.kt 86.06% <80.00%> (+0.58%) ⬆️
...ndroid/embracesdk/logging/InternalEmbraceLogger.kt 90.90% <93.33%> (+25.52%) ⬆️
...d/embracesdk/logging/InternalErrorServiceAction.kt 85.71% <85.71%> (ø)
... and 3 more

... and 9 files with indirect coverage changes

Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yessssss. LGTM

@fractalwrench fractalwrench merged commit 307d284 into master May 10, 2024
4 checks passed
@fractalwrench fractalwrench deleted the remove-strict-mode branch May 10, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants