Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline logcat action #826

Merged
merged 1 commit into from
May 10, 2024
Merged

Conversation

fractalwrench
Copy link
Contributor

Goal

Inlines the action that sends a message to logcat.

Testing

Relied on existing test coverage.

@fractalwrench fractalwrench requested a review from a team as a code owner May 9, 2024 14:32
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.42%. Comparing base (79e2ce0) to head (011a008).

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                    @@
##           remove-dead-log-code     #826      +/-   ##
========================================================
- Coverage                 81.46%   81.42%   -0.05%     
========================================================
  Files                       426      425       -1     
  Lines                     11325    11358      +33     
  Branches                   1681     1689       +8     
========================================================
+ Hits                       9226     9248      +22     
- Misses                     1391     1401      +10     
- Partials                    708      709       +1     
Files Coverage Δ
...ndroid/embracesdk/logging/InternalEmbraceLogger.kt 90.90% <100.00%> (+4.24%) ⬆️

... and 12 files with indirect coverage changes

Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fractalwrench fractalwrench merged commit 2a8cb2d into remove-dead-log-code May 10, 2024
3 checks passed
@fractalwrench fractalwrench deleted the inline-logcat-action branch May 10, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants