Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename & document log actions #824

Merged
merged 5 commits into from
May 10, 2024
Merged

Rename & document log actions #824

merged 5 commits into from
May 10, 2024

Conversation

fractalwrench
Copy link
Contributor

Goal

Renames the LoggerAction interface to LogAction and adds some missing documentation.

Testing

Relied on existing test coverage.

@fractalwrench fractalwrench requested a review from a team as a code owner May 9, 2024 13:43
bidetofevil
bidetofevil approved these changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fractalwrench fractalwrench merged commit e504e3f into remove-strict-mode May 10, 2024
1 check passed
@fractalwrench fractalwrench deleted the rename-logger-actions branch May 10, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bidetofevil bidetofevil bidetofevil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fractalwrench @bidetofevil