Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fallback start time values for cases where process creation time is unavailable #564

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

bidetofevil
Copy link
Collaborator

@bidetofevil bidetofevil commented Mar 13, 2024

Goal

A previous refactoring switched up the orders of two variables, which lead to there not being a start time for startup traces between Android versions 7 to 13. This fixes that mistake and includes a bunch of tests that verify for each relevant version that traces are logged properly if the expected events are calls.

Testing

Added additional tests to catch this case in the futre

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.13%. Comparing base (0c8dd3a) to head (2abe4a2).
Report is 1 commits behind head on master.

❗ Current head 2abe4a2 differs from pull request most recent head f69b03b. Consider uploading reports for the commit f69b03b to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #564   +/-   ##
=======================================
  Coverage   80.12%   80.13%           
=======================================
  Files         413      413           
  Lines       11041    11041           
  Branches     1624     1624           
=======================================
+ Hits         8847     8848    +1     
  Misses       1543     1543           
+ Partials      651      650    -1     
Files Coverage Δ
...bracesdk/capture/startup/AppStartupTraceEmitter.kt 73.61% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator Author

bidetofevil commented Mar 14, 2024

Merge activity

  • Mar 14, 2:38 AM EDT: @bidetofevil started a stack merge that includes this pull request via Graphite.
  • Mar 14, 2:39 AM EDT: Graphite rebased this pull request as part of a merge.
  • Mar 14, 2:40 AM EDT: @bidetofevil merged this pull request with Graphite.

Base automatically changed from hho/init-native-cash-monitor-async to master March 14, 2024 06:38
@bidetofevil bidetofevil merged commit 1fdead5 into master Mar 14, 2024
3 checks passed
@bidetofevil bidetofevil deleted the hho/fix-startup-trace branch March 14, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants