Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer aspects of API service load until necessary #539

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

bidetofevil
Copy link
Collaborator

@bidetofevil bidetofevil commented Mar 11, 2024

Goal

Both the ApiRequestMapper and the configUrl are expensive to initialize, so we do it lazily when they are actually needed

@bidetofevil bidetofevil force-pushed the hho/defer-session-properties-load branch from 49735fc to b58b0dd Compare March 11, 2024 06:37
@bidetofevil bidetofevil force-pushed the hho/defer-session-properties-load branch from b58b0dd to b3b9481 Compare March 11, 2024 06:54
@bidetofevil bidetofevil marked this pull request as ready for review March 11, 2024 07:28
@bidetofevil bidetofevil requested a review from a team as a code owner March 11, 2024 07:28
@bidetofevil bidetofevil requested review from fractalwrench and a team and removed request for a team March 11, 2024 07:28
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 89.60000% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 79.69%. Comparing base (5e18d90) to head (a289a42).
Report is 8 commits behind head on master.

❗ Current head a289a42 differs from pull request most recent head 4dbec98. Consider uploading reports for the commit 4dbec98 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #539      +/-   ##
==========================================
+ Coverage   79.45%   79.69%   +0.23%     
==========================================
  Files         403      403              
  Lines       10861    10902      +41     
  Branches     1602     1607       +5     
==========================================
+ Hits         8630     8688      +58     
+ Misses       1585     1569      -16     
+ Partials      646      645       -1     
Files Coverage Δ
...cesdk/anr/ndk/EmbraceNativeThreadSamplerService.kt 90.83% <100.00%> (+2.79%) ⬆️
.../android/embracesdk/comms/api/EmbraceApiService.kt 90.24% <100.00%> (+0.63%) ⬆️
.../io/embrace/android/embracesdk/ndk/NativeModule.kt 100.00% <100.00%> (+21.95%) ⬆️
...embracesdk/anr/ndk/NativeThreadSamplerInstaller.kt 57.14% <50.00%> (+0.89%) ⬆️
...roid/embracesdk/capture/user/EmbraceUserService.kt 72.85% <93.10%> (+6.19%) ⬆️
.../android/embracesdk/internal/SharedObjectLoader.kt 64.28% <61.53%> (-21.43%) ⬇️
...sdk/session/properties/EmbraceSessionProperties.kt 83.33% <89.13%> (+1.85%) ⬆️

... and 7 files with indirect coverage changes

Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but would be nice to use property delegation

Copy link
Collaborator Author

bidetofevil commented Mar 11, 2024

Merge activity

  • Mar 11, 11:07 AM EDT: @bidetofevil started a stack merge that includes this pull request via Graphite.
  • Mar 11, 11:14 AM EDT: Graphite rebased this pull request as part of a merge.
  • Mar 11, 11:15 AM EDT: @bidetofevil merged this pull request with Graphite.

@bidetofevil bidetofevil force-pushed the hho/defer-session-properties-load branch from b3b9481 to abcc1ea Compare March 11, 2024 15:11
Base automatically changed from hho/defer-session-properties-load to master March 11, 2024 15:13
@bidetofevil bidetofevil merged commit 9c408be into master Mar 11, 2024
2 of 3 checks passed
@bidetofevil bidetofevil deleted the hho/defer-api-service-load branch March 11, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants