-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Defer aspects of API service load until necessary #539
Conversation
49735fc
to
b58b0dd
Compare
6cc8385
to
e39bf3d
Compare
b58b0dd
to
b3b9481
Compare
e39bf3d
to
a289a42
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #539 +/- ##
==========================================
+ Coverage 79.45% 79.69% +0.23%
==========================================
Files 403 403
Lines 10861 10902 +41
Branches 1602 1607 +5
==========================================
+ Hits 8630 8688 +58
+ Misses 1585 1569 -16
+ Partials 646 645 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but would be nice to use property delegation
embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/comms/api/EmbraceApiService.kt
Outdated
Show resolved
Hide resolved
embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/comms/api/EmbraceApiService.kt
Outdated
Show resolved
Hide resolved
Merge activity
|
b3b9481
to
abcc1ea
Compare
6c908df
to
4dbec98
Compare
Goal
Both the ApiRequestMapper and the configUrl are expensive to initialize, so we do it lazily when they are actually needed