-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Defer session properties load until it's really needed #538
Conversation
6d184ca
to
35c879f
Compare
49735fc
to
b58b0dd
Compare
35c879f
to
e028f97
Compare
b58b0dd
to
b3b9481
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #538 +/- ##
==========================================
+ Coverage 79.45% 79.65% +0.19%
==========================================
Files 403 403
Lines 10861 10897 +36
Branches 1602 1607 +5
==========================================
+ Hits 8630 8680 +50
+ Misses 1585 1572 -13
+ Partials 646 645 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merge activity
|
e028f97
to
41b9ac8
Compare
b3b9481
to
abcc1ea
Compare
Goal
Similar to UserInfo, SessionProperties were also being initialized premature. Defer this to when it's actually read and synchronize access.
Testing
Existing tests cover this.