Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer session properties load until it's really needed #538

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

bidetofevil
Copy link
Collaborator

@bidetofevil bidetofevil commented Mar 11, 2024

Goal

Similar to UserInfo, SessionProperties were also being initialized premature. Defer this to when it's actually read and synchronize access.

Testing

Existing tests cover this.

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 87.37864% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 79.65%. Comparing base (5e18d90) to head (b3b9481).
Report is 6 commits behind head on master.

❗ Current head b3b9481 differs from pull request most recent head abcc1ea. Consider uploading reports for the commit abcc1ea to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #538      +/-   ##
==========================================
+ Coverage   79.45%   79.65%   +0.19%     
==========================================
  Files         403      403              
  Lines       10861    10897      +36     
  Branches     1602     1607       +5     
==========================================
+ Hits         8630     8680      +50     
+ Misses       1585     1572      -13     
+ Partials      646      645       -1     
Files Coverage Δ
...cesdk/anr/ndk/EmbraceNativeThreadSamplerService.kt 90.83% <100.00%> (+2.79%) ⬆️
.../io/embrace/android/embracesdk/ndk/NativeModule.kt 100.00% <100.00%> (+21.95%) ⬆️
...embracesdk/anr/ndk/NativeThreadSamplerInstaller.kt 57.14% <50.00%> (+0.89%) ⬆️
...roid/embracesdk/capture/user/EmbraceUserService.kt 72.85% <93.10%> (+6.19%) ⬆️
.../android/embracesdk/internal/SharedObjectLoader.kt 64.28% <61.53%> (-21.43%) ⬇️
...sdk/session/properties/EmbraceSessionProperties.kt 83.33% <89.13%> (+1.85%) ⬆️

... and 6 files with indirect coverage changes

Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator Author

bidetofevil commented Mar 11, 2024

Merge activity

  • Mar 11, 11:07 AM EDT: @bidetofevil started a stack merge that includes this pull request via Graphite.
  • Mar 11, 11:12 AM EDT: Graphite rebased this pull request as part of a merge.
  • Mar 11, 11:13 AM EDT: @bidetofevil merged this pull request with Graphite.

Base automatically changed from hho/defer-user-info-load to master March 11, 2024 15:11
@bidetofevil bidetofevil force-pushed the hho/defer-session-properties-load branch from b3b9481 to abcc1ea Compare March 11, 2024 15:11
@bidetofevil bidetofevil merged commit d6103c8 into master Mar 11, 2024
3 checks passed
@bidetofevil bidetofevil deleted the hho/defer-session-properties-load branch March 11, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants