Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GitHub warnings #931

Merged
merged 15 commits into from
Feb 17, 2023
Merged

Fix GitHub warnings #931

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
f8b6813
move server definition to package protocols
localvar Jan 17, 2023
34fe51c
refactor: folder structure for proxies
localvar Jan 30, 2023
5d4d882
refactor load balancer (WIP)
localvar Feb 1, 2023
200992f
continue refactor load balancer
localvar Feb 2, 2023
d684f5a
refactor load balance complete.
localvar Feb 2, 2023
01c9056
fix tests
localvar Feb 2, 2023
3757e34
refactor request matcher
localvar Feb 3, 2023
5b83b5c
fix bugs
localvar Feb 5, 2023
7cdca74
add RealIP to Request interface
localvar Feb 6, 2023
faae5f0
move StringMatcher to package stringtool
localvar Feb 6, 2023
7bf022c
remove some redundant code
localvar Feb 8, 2023
0bee4bb
Apply suggestions from code review
localvar Feb 9, 2023
8cae22c
fix github action warnings
localvar Feb 9, 2023
5790d9f
Merge branch 'main' into fix-github-warnings
localvar Feb 17, 2023
23f3959
more fixes
localvar Feb 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
Next Next commit
fix bugs
  • Loading branch information
@localvar
localvar committed Feb 6, 2023
commit 5b83b5cb7ea9a186c4e3ede47b80808ffaf803b2
3 changes: 2 additions & 1 deletion pkg/filters/proxies/loadbalance.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ func (glb *GeneralLoadBalancer) checkServers() {
}
svr.HealthCounter--
if svr.Healthy() && svr.HealthCounter <= -glb.spec.HealthCheck.Fails {
logger.Warnf("server:%v becomes healthy.", svr.ID())
logger.Warnf("server:%v becomes unhealthy.", svr.ID())
svr.Unhealth = true
changed = true
}
Expand Down Expand Up @@ -226,6 +226,7 @@ func (glb *GeneralLoadBalancer) ReturnServer(server *Server, req protocols.Reque
// Close closes the load balancer
func (glb *GeneralLoadBalancer) Close() {
if glb.hc != nil {
close(glb.done)
glb.hc.Close()
}
if glb.ss != nil {
Expand Down