Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub warnings #931

Merged
merged 15 commits into from
Feb 17, 2023
Prev Previous commit
Next Next commit
Apply suggestions from code review
Co-authored-by: Groot <[email protected]>
  • Loading branch information
localvar and grootpiano committed Feb 9, 2023
commit 0bee4bbae9da98bc1fc68277d01064a3b49f1f11
2 changes: 1 addition & 1 deletion pkg/filters/proxies/grpcproxy/requestmatch.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ type RequestMatcherSpec struct {
Methods []*stringtool.StringMatcher `json:"methods" jsonschema:"omitempty"`
}

// Validate validtes the RequestMatcherSpec.
// Validate validates the RequestMatcherSpec.
func (s *RequestMatcherSpec) Validate() error {
if err := s.RequestMatcherBaseSpec.Validate(); err != nil {
return err
Expand Down
2 changes: 1 addition & 1 deletion pkg/filters/proxies/httpproxy/requestmatch.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ type RequestMatcherSpec struct {
URLs []*MethodAndURLMatcher `json:"urls" jsonschema:"omitempty"`
}

// Validate validtes the RequestMatcherSpec.
// Validate validates the RequestMatcherSpec.
func (s *RequestMatcherSpec) Validate() error {
if err := s.RequestMatcherBaseSpec.Validate(); err != nil {
return err
Expand Down
2 changes: 1 addition & 1 deletion pkg/filters/proxies/requestmatch.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ type RequestMatcherBaseSpec struct {
HeaderHashKey string `json:"headerHashKey" jsonschema:"omitempty"`
}

// Validate validtes the RequestMatcherBaseSpec.
// Validate validates the RequestMatcherBaseSpec.
func (s *RequestMatcherBaseSpec) Validate() error {
if s.Policy == "general" || s.Policy == "" {
if len(s.Headers) == 0 {
Expand Down