Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub warnings #931

Merged
merged 15 commits into from
Feb 17, 2023
Prev Previous commit
Next Next commit
fix tests
  • Loading branch information
localvar committed Feb 3, 2023
commit 01c9056dd9bded75bbc44cbd96461a20fe3cd48d
1 change: 1 addition & 0 deletions pkg/filters/proxies/loadbalance_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ func TestGeneralLoadBalancer(t *testing.T) {

lb.Close()

servers = prepareServers(10)
lb = NewGeneralLoadBalancer(spec, servers)

lb.Init(NewHTTPSessionSticker, func(hcs *HealthCheckSpec) HealthChecker {
Expand Down
23 changes: 12 additions & 11 deletions pkg/object/meshcontroller/spec/spec_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import (
"testing"

"github.com/megaease/easegress/pkg/filters/mock"
"github.com/megaease/easegress/pkg/filters/proxies"
proxy "github.com/megaease/easegress/pkg/filters/proxies/httpproxy"
"github.com/megaease/easegress/pkg/filters/ratelimiter"
"github.com/megaease/easegress/pkg/logger"
Expand Down Expand Up @@ -195,7 +196,7 @@ func TestSidecarEgressPipelineSpec(t *testing.T) {
s := &Service{
Name: "delivery-mesh",
LoadBalance: &LoadBalance{
Policy: proxy.LoadBalancePolicyIPHash,
Policy: proxies.LoadBalancePolicyIPHash,
},
Sidecar: &Sidecar{
Address: "127.0.0.1",
Expand Down Expand Up @@ -258,7 +259,7 @@ func TestSidecarEgressPipelineWithCanarySpec(t *testing.T) {
s := &Service{
Name: "order-002-canary",
LoadBalance: &LoadBalance{
Policy: proxy.LoadBalancePolicyIPHash,
Policy: proxies.LoadBalancePolicyIPHash,
},
Sidecar: &Sidecar{
Address: "127.0.0.1",
Expand Down Expand Up @@ -422,7 +423,7 @@ func TestSidecarEgressPipelineWithMultipleCanarySpec(t *testing.T) {
s := &Service{
Name: "order-003-canary-array",
LoadBalance: &LoadBalance{
Policy: proxy.LoadBalancePolicyIPHash,
Policy: proxies.LoadBalancePolicyIPHash,
},
Sidecar: &Sidecar{
Address: "127.0.0.1",
Expand Down Expand Up @@ -471,7 +472,7 @@ func TestSidecarEgressPipelineWithCanaryNoInstanceSpec(t *testing.T) {
s := &Service{
Name: "order-004-canary-no-instance",
LoadBalance: &LoadBalance{
Policy: proxy.LoadBalancePolicyIPHash,
Policy: proxies.LoadBalancePolicyIPHash,
},
Sidecar: &Sidecar{
Address: "127.0.0.1",
Expand Down Expand Up @@ -520,7 +521,7 @@ func TestSidecarEgressPipelineWithCanaryInstanceMultipleLabelSpec(t *testing.T)
s := &Service{
Name: "order-005-canary-instance-multiple-label",
LoadBalance: &LoadBalance{
Policy: proxy.LoadBalancePolicyIPHash,
Policy: proxies.LoadBalancePolicyIPHash,
},
Sidecar: &Sidecar{
Address: "127.0.0.1",
Expand Down Expand Up @@ -589,7 +590,7 @@ func TestSidecarIngressWithResiliencePipelineSpec(t *testing.T) {
s := &Service{
Name: "order-001",
LoadBalance: &LoadBalance{
Policy: proxy.LoadBalancePolicyRandom,
Policy: proxies.LoadBalancePolicyRandom,
},
Sidecar: &Sidecar{
Address: "127.0.0.1",
Expand Down Expand Up @@ -630,7 +631,7 @@ func TestSidecarEgressResiliencePipelineSpec(t *testing.T) {
s := &Service{
Name: "order-001",
LoadBalance: &LoadBalance{
Policy: proxy.LoadBalancePolicyIPHash,
Policy: proxies.LoadBalancePolicyIPHash,
},
Sidecar: &Sidecar{
Address: "127.0.0.1",
Expand Down Expand Up @@ -738,7 +739,7 @@ func TestIngressPipelineSpec(t *testing.T) {
s := &Service{
Name: "order-001",
LoadBalance: &LoadBalance{
Policy: proxy.LoadBalancePolicyRandom,
Policy: proxies.LoadBalancePolicyRandom,
},
Sidecar: &Sidecar{
Address: "127.0.0.1",
Expand Down Expand Up @@ -790,7 +791,7 @@ func TestSidecarIngressPipelineSpecCert(t *testing.T) {
s := &Service{
Name: "order-001",
LoadBalance: &LoadBalance{
Policy: proxy.LoadBalancePolicyRandom,
Policy: proxies.LoadBalancePolicyRandom,
},
Sidecar: &Sidecar{
Address: "127.0.0.1",
Expand Down Expand Up @@ -835,7 +836,7 @@ func TestSidecarIngressPipelineSpec(t *testing.T) {
s := &Service{
Name: "order-001",
LoadBalance: &LoadBalance{
Policy: proxy.LoadBalancePolicyRandom,
Policy: proxies.LoadBalancePolicyRandom,
},
Sidecar: &Sidecar{
Address: "127.0.0.1",
Expand Down Expand Up @@ -865,7 +866,7 @@ func TestEgressName(t *testing.T) {
s := &Service{
Name: "order-001",
LoadBalance: &LoadBalance{
Policy: proxy.LoadBalancePolicyRandom,
Policy: proxies.LoadBalancePolicyRandom,
},
Sidecar: &Sidecar{
Address: "127.0.0.1",
Expand Down