update based on githubci lint

pkg/filters/proxies/loadbalance_test.go

@@ -129,15 +129,15 @@ func TestWeightedRandomLoadBalancePolicy(t *testing.T) {
  lb := NewGeneralLoadBalancer(&LoadBalanceSpec{Policy: LoadBalancePolicyWeightedRandom}, servers)
  lb.Init(nil, nil, nil)
 
- for i := 0; i < 1000; i++ {
+ for i := 0; i < 50000; i++ {
  svr := lb.ChooseServer(nil)
  counter[svr.Weight-1]++
  }
 
  v := 0
  for i := 0; i < 10; i++ {
  if v >= counter[i] {
- t.Error("possibility is not weighted even")
+ t.Errorf("possibility is not weighted even %v", counter)
  }
  v = counter[i]
  }

pkg/protocols/httpprot/httpheader/validator.go

@@ -77,23 +77,20 @@ func NewValidator(spec *ValidatorSpec) *Validator {
 func (v Validator) Validate(h *HTTPHeader) error {
  for key, vv := range *v.spec {
  values := h.GetAll(key)
- if len(values) == 0 {
- return fmt.Errorf("header %s not found", key)
- }
- // check all Values in validator are in header
- for _, v := range vv.Values {
- if !stringtool.StrInSlice(v, values) {
- return fmt.Errorf("header %s not contain value %s", key, v)
+ valid := false
+ for _, value := range values {
+ if stringtool.StrInSlice(value, vv.Values) {
+ valid = true
+ break
  }
- }
- // check all values in header match regexp
- if vv.re != nil {
- for _, value := range values {
- if !vv.re.MatchString(value) {
- return fmt.Errorf("header %s:%s is invalid", key, value)
- }
+ if vv.re != nil && vv.re.MatchString(value) {
+ valid = true
+ break
  }
  }
+ if !valid {
+ return fmt.Errorf("header %s is invalid", key)
+ }
  }
  return nil
 }