Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add golangci lint to github action workflow #1068

Merged
merged 15 commits into from
Aug 31, 2023
Merged

add golangci lint to github action workflow #1068

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
ec3a491
add golangci lint to github action workflow
suchen-sci Aug 28, 2023
07ad3b7
add golang ci
suchen-sci Aug 28, 2023
8848eb1
update code based on golangci lint
suchen-sci Aug 28, 2023
a731041
update workflow
suchen-sci Aug 28, 2023
4747a4e
update based on githubci lint
suchen-sci Aug 28, 2023
9a3d0f8
update based on githubci lint
suchen-sci Aug 28, 2023
26ad18a
update based on githubci lint
suchen-sci Aug 28, 2023
15983e2
update based on githubci lint
suchen-sci Aug 28, 2023
1445cc4
update based on githubci lint
suchen-sci Aug 28, 2023
65e9614
update based on githubci lint
suchen-sci Aug 28, 2023
ae74b8a
update based on githubci lint
suchen-sci Aug 28, 2023
db1b606
update based on githubci lint
suchen-sci Aug 29, 2023
be7ec3c
update based on githubci lint
suchen-sci Aug 29, 2023
63392b8
update golang ci lint
suchen-sci Aug 29, 2023
34d4174
update grpc related change
suchen-sci Aug 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
update grpc related change
  • Loading branch information
@suchen-sci
suchen-sci committed Aug 29, 2023
commit 34d41742f8d0c54cb38bc7cd2a7b4e0c8327b0ad
3 changes: 2 additions & 1 deletion pkg/filters/proxies/grpcproxy/proxy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,8 @@ var (
defaultDialOpts = []grpc.DialOption{
grpc.WithTransportCredentials(insecure.NewCredentials()),
grpc.WithDefaultCallOptions(grpc.ForceCodec(&GrpcCodec{})),
grpc.WithBlock()}
grpc.WithBlock(),
}
)

var _ filters.Filter = (*Proxy)(nil)
Expand Down
5 changes: 4 additions & 1 deletion pkg/object/grpcserver/runtime.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@ import (
"google.golang.org/grpc/keepalive"
)

func init() {
encoding.RegisterCodec(&grpcproxy.GrpcCodec{})
}

const (
stateNil stateType = "nil"
stateFailed stateType = "failed"
Expand Down Expand Up @@ -220,7 +224,6 @@ func (r *runtime) startServer() {
r.setError(err)
return
}
encoding.RegisterCodec(&grpcproxy.GrpcCodec{})
opts := []grpc.ServerOption{grpc.UnknownServiceHandler(r.mux.handler)}
keepaliveOpts := r.buildServerKeepaliveOpt()

Expand Down