add golangci lint to github action workflow #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
suchen-sci
commented
Aug 28, 2023
•
suchen-sci
commented
- rm unused files, variables, consts
- rm unnecessary type assert for switch
- some are deprecated, need to update
- other unnecessary operations
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #1068 +/- ##
==========================================
- Coverage 81.47% 81.45% -0.02%
==========================================
Files 136 139 +3
Lines 15404 15447 +43
==========================================
+ Hits 12551 12583 +32
- Misses 2276 2287 +11
Partials 577 577
☔ View full report in Codecov by Sentry. |
suchen-sci
force-pushed
the
golangci-lint
branch
from
4061280
to
07ad3b7
Compare
suchen-sci
commented
Aug 29, 2023
| @@ -40,8 +38,6 @@ import ( | |||
|
|
|||
| // RunServer runs Easegress server. | |||
| func RunServer() { | |||
| rand.Seed(time.Now().UnixNano()) | |||
|
|
|||
There was a problem hiding this comment.
rand.Seed is deprecated since golang 1.20
| "fmt" | ||
| "math/rand" |
There was a problem hiding this comment.
replace with math/rand with crypto/rand for rand.Read
| supervisor := supervisor.NewMock( | ||
| nil, clusterInstance, mockMap, mockMap, nil, nil, false, nil, nil) |
There was a problem hiding this comment.
sync.Map contains lock, can't be copy.
| @@ -52,8 +51,6 @@ type ( | |||
| // MeshAdaptor is filter MeshAdaptor. | |||
| MeshAdaptor struct { | |||
| spec *Spec | |||
|
|
|||
| pa *pathadaptor.PathAdaptor | |||
| @@ -293,7 +293,7 @@ func (o *OIDCAdaptor) handleOIDCCallback(ctx *context.Context) string { | |||
| return "" | |||
| } | |||
|
|
|||
| func (o *OIDCAdaptor) fetchOIDCToken(authCode string, state string, spec *Spec, err error, rw *httpprot.Response, req *httpprot.Request) (*oidcIDToken, error) { | |||
There was a problem hiding this comment.
this err is assigned before use in this function, so remove it.
| @@ -46,10 +46,6 @@ type ( | |||
| errRate5 metrics.EWMA | |||
| errRate15 metrics.EWMA | |||
|
|
|||
| m1ErrPercent float64 | |||
| "github.com/megaease/easegress/v2/pkg/cluster" | ||
| "github.com/megaease/easegress/v2/pkg/option" | ||
| ) | ||
|
|
||
| // NewMock return a mock supervisor for testing purpose | ||
| func NewMock(options *option.Options, cls cluster.Cluster, businessControllers sync.Map, |
There was a problem hiding this comment.
remove sync.Map.
| @@ -52,25 +52,24 @@ func JSONToKVMap(jsonStr string) (map[string]string, error) { | |||
| func extractKVs(prefix string, obj interface{}) []map[string]string { | |||
| var rst []map[string]string | |||
|
|
|||
| switch obj.(type) { | |||
There was a problem hiding this comment.
unnecessary type assertion.
| @@ -68,7 +68,8 @@ func runCase(s *Semaphore, maxCount int64, t *testing.T) { | |||
| wg.Wait() | |||
|
|
|||
| // step 2: try to acquire one more, should timeout | |||
| ctx, _ := context.WithTimeout(context.Background(), 100*time.Millisecond) | |||
There was a problem hiding this comment.
not call cancel.
| @@ -50,53 +50,53 @@ type ( | |||
| Literal struct { | |||
| // ScopeSuffix is the last part when build the credential scope. | |||
| // Default: megaease_request | |||
| ScopeSuffix string `json:"scopeSuffix" json:"scopeSuffix" jsonschema:"required"` | |||
xxx7xxxx
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.