Refactor exam evaluation generation

evap/evaluation/models.py

@@ -3,7 +3,7 @@
 import uuid
 from collections import defaultdict
 from dataclasses import dataclass
-from datetime import date, datetime, timedelta
+from datetime import date, datetime, time, timedelta
 from enum import Enum, auto
 from numbers import Real
 
@@ -443,6 +443,19 @@ class State:
  verbose_name=_("wait for grade upload before publishing"), default=True
  )
 
+ @property
+ def has_exam(self):
+ return self.course.evaluations.filter(name_de="Klausur", name_en="Exam").exists()
+
+ def make_exam_evaluation(self, exam_date: date, participants, eval_contributions):
+ self.vote_start_datetime = datetime.combine(exam_date + timedelta(days=1), time(8, 0))
+ self.vote_end_date = exam_date + timedelta(days=3)
+ self.save()
+ self.participants.set(participants)
+ for contribution in eval_contributions:
+ self.contributions.create(contributor=contribution.contributor)
+ self.general_contribution.questionnaires.set(settings.EXAM_QUESTIONNAIRES)
+
  class TextAnswerReviewState(Enum):
  do_not_call_in_templates = True # pylint: disable=invalid-name
  NO_TEXTANSWERS = auto()

evap/staff/templates/staff_semester_view_evaluation.html

@@ -188,7 +188,7 @@
  <a href="{% url 'staff:evaluation_copy' evaluation.id %}" class="btn btn-sm btn-light" data-bs-toggle="tooltip" title="{% translate "Copy" %}">
  <span class="fas fa-copy"></span>
  </a>
- {% if evaluation.has_exam%}
+ {% if not evaluation.has_exam%}
  <a class="btn btn-sm btn-dark" data-bs-toggle="tooltip" 
  onclick="createExamEvaluationShow({{ evaluation.id }}, '{{ course.name|escapejs }}');" 
  title="{% trans 'Create exam evaluation' %}"> 

evap/staff/views.py

@@ -241,9 +241,6 @@ class Stats:
  degree_stats_with_total = cast(dict[Degree | str, Stats], degree_stats)
  degree_stats_with_total["total"] = total_stats
 
- for evaluation in evaluations:
- evaluation.has_exam = evaluation.course.evaluations.filter(name_de="Klausur", name_en="Exam").exists()
-
  template_data = {
  "semester": semester,
  "evaluations": evaluations,
@@ -1066,23 +1063,22 @@ def create_exam_evaluation(request):
  if evaluation.course.evaluations.filter(name_de="Klausur", name_en="Exam").exists():
  raise SuspiciousOperation("An exam evaluation already exists for this course.")
 
- evaluation.weight = 9
  evaluation_end_date = exam_date - timedelta(days=1)
  if evaluation.vote_start_datetime > evaluation_end_date:
  raise SuspiciousOperation("The exam date is before the start date of the main evaluation")
+
+ evaluation.weight = 9
  evaluation.vote_end_date = evaluation_end_date
  evaluation.save()
 
  exam_evaluation = Evaluation(
  course=evaluation.course, name_de="Klausur", name_en="Exam", weight=1, is_rewarded=False
  )
- exam_evaluation.vote_start_datetime = datetime.combine(exam_date + timedelta(days=1), time(8, 0))
- exam_evaluation.vote_end_date = exam_date + timedelta(days=3)
- exam_evaluation.save()
- exam_evaluation.participants.set(evaluation.participants.all())
- for contribution in evaluation.contributions.exclude(contributor=None):
- exam_evaluation.contributions.create(contributor=contribution.contributor)
- exam_evaluation.general_contribution.questionnaires.set(settings.EXAM_QUESTIONNAIRES)
+ exam_evaluation.make_exam_evaluation(
+ exam_date=exam_date,
+ participants=evaluation.participants.all(),
+ eval_contributions=evaluation.contributions.exclude(contributor=None),
+ )
  messages.success(request, _("Successfully created exam evaluation."))
  return HttpResponse() # 200 OK