Added tests

evap/staff/tests/test_views.py

@@ -1959,6 +1959,25 @@ def test_create_exam_evaluation(self):
  self.assertEqual(exam_evaluation.participants.count(), self.evaluation.participants.count())
  self.assertEqual(exam_evaluation.weight, 1)
 
+ def test_exam_evaluation_for_single_result(self):
+ self.evaluation.is_single_result = True
+ self.evaluation.save()
+ self.app.post(self.url, user=self.manager, status=400, params={"evaluation_id": self.evaluation.pk})
+ self.assertFalse(self.evaluation.has_exam)
+
+ def test_exam_evaluation_for_already_existing_exam_evaluation(self):
+ baker.make(Evaluation, course=self.course, name_en="Exam", name_de="Klausur")
+ self.assertTrue(self.evaluation.has_exam)
+ self.app.post(self.url, user=self.manager, status=400, params={"evaluation_id": self.evaluation.pk})
+
+ def test_exam_evaluation_with_wrong_date(self):
+ self.evaluation.vote_start_datetime = datetime.datetime.now() + datetime.timedelta(days=100)
+ self.evaluation.vote_end_date = datetime.date.today() + datetime.timedelta(days=150)
+ self.evaluation.save()
+
+ self.app.post(self.url, user=self.manager, status=400, params={"evaluation_id": self.evaluation.pk})
+ self.assertFalse(self.evaluation.has_exam)
+
 
 class TestCourseCopyView(WebTestStaffMode):
  @classmethod

evap/staff/views.py

@@ -1060,7 +1060,7 @@ def create_exam_evaluation(request):
  if evaluation.is_single_result:
  raise SuspiciousOperation("Creating an exam evaluation for a single result evaluation is not allowed")
 
- if evaluation.course.evaluations.filter(name_de="Klausur", name_en="Exam").exists():
+ if evaluation.has_exam:
  raise SuspiciousOperation("An exam evaluation already exists for this course.")
 
  evaluation_end_date = exam_date - timedelta(days=1)