Adds shortcut button to add exam evaluation #2050
Conversation
|
@FSadrieh Modals are merged so you should be un-blocked here now |
FSadrieh
force-pushed
the
shortcut-to-exam
branch
from
6adf24a
to
6597968
Compare
… and teeeeeeeeeeeeeeeeeeeeeeeeeests
FSadrieh
force-pushed
the
shortcut-to-exam
branch
from
635006f
to
b1e3957
Compare
evap/staff/views.py
Outdated
| if evaluation.vote_start_datetime > evaluation_end_date: | ||
| messages.error( | ||
| request, _("The exam date is before the start date of the main evaluation. No exam evaluation was created.") | ||
| ) | ||
| return HttpResponse() |
There was a problem hiding this comment.
I don't think the message flow makes sense here (as is reflected in the test for this): The post request will be answered with an empty HTTP 200 OK -- how would a user get that error? To my understanding, they would only see that once they go to a new page, right?
If this error is possible to be triggered by a user, they should get a meaningful error immediately.
(A post-only REST handler setting an error in the messages framework generall seems not really useful to me)
There was a problem hiding this comment.
@niklasmohrin we settled to check the date when the user submits the modal, similar to the semester deletion modal (See the new commit). One problem we currently face is the error message disappearing fast as the modal closes on click. How would this feature work best with the confirmation modal?
| {% for evaluation in evaluations %} | ||
| <form id="exam_creation_form_{{ evaluation.id }}" reload-on-success method="post" action="{% url 'staff:create_exam_evaluation' %}"> |
There was a problem hiding this comment.
Given that except for the id, all these forms are equal, we really only need one
| {% if not evaluation.has_exam %} | ||
| <confirmation-modal type="submit" id="exam_creation_modal" name="evaluation_id" value="{{ evaluation.id }}" confirm-button-class="btn-primary" form="exam_creation_form_{{ evaluation.id }}"> |
There was a problem hiding this comment.
The id of these modals will be duplicated when there is more than one applicable evaluation - I think we don't need the id anyways, in that case let's just remove it
There was a problem hiding this comment.
I do not think we can remove it. Without id it throws: ValueError: "<Evaluation: Database Systems I – Exam>" needs to have a value for field "id" before this many-to-many relationship can be used.
| </span> | ||
| <span slot="extra-inputs"> | ||
| <label for="exam_date">{% translate 'Exam Date:' %}</label> | ||
| <input type="date" id="exam_date" name="exam_date" required form="exam_creation_form_{{ evaluation.id }}"> |
There was a problem hiding this comment.
This id will also be duplicated. We could include the evaluation's id, or it should also work to move the input element into the label element, then we don't need the id and for attributes (see https://developer.mozilla.org/en-US/docs/Web/HTML/Element/label). I think I prefer the second approach, we would have to make sure it also works with type="date" though :)
#2008