Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mobile selection #2559

Closed
wants to merge 26 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
91797ec
feat: init basic mobile features
wzhudev Jun 7, 2024
9719d1f
fix: rollback desktop changes
wzhudev Jun 7, 2024
a0702ce
feat: demonstrate removing canvas features
wzhudev Jun 7, 2024
afd0598
feat: enable filter rendering
wzhudev Jun 7, 2024
12a3d7f
feat: support formula over web worker
wzhudev Jun 11, 2024
a137899
feat: add mobile header
wzhudev Jun 11, 2024
19be9fd
feat: enable data validation
wzhudev Jun 11, 2024
c26bff6
feat: enable conditional formatting
wzhudev Jun 11, 2024
bce2a36
feat: add mobile worksheet
wzhudev Jun 11, 2024
2d92507
feat: add mobile jsdoc
wzhudev Jun 11, 2024
0433526
feat: add scroll into view
wzhudev Jun 11, 2024
23863ca
feat: mobile context menu
wzhudev Jun 11, 2024
0cf29f5
fix: change header style
wzhudev Jun 11, 2024
fb772fd
feat: context menu ui
wzhudev Jun 13, 2024
cda2931
chore: code style
wzhudev Jun 14, 2024
256d5c1
docs: update render unit drawing
wzhudev Jun 17, 2024
617c03c
Merge remote-tracking branch 'origin/dev' into feat/mobile-poc
wzhudev Jun 17, 2024
69acd64
feat(sheets-ui): optimize ref-range for hyper-link and thread-comment…
weird94 Jun 7, 2024
23865ce
fix: draw dashrect in visible area
lumixraku Jun 3, 2024
aa41b90
feat: mobile selection
lumixraku Jun 11, 2024
978edf8
chore: better shape style
lumixraku Jun 21, 2024
1f2a572
fix: popup position when scrolled
lumixraku Jun 21, 2024
1985536
chore: add rangetype when update control
lumixraku Jun 21, 2024
9df2f6c
chore: move dash logic into dashedrect
lumixraku Jun 19, 2024
cb2fa8d
test: change selection shape Y when scrolling
lumixraku Jun 26, 2024
f152d32
feat: use scrollInfo$ to control scrolling
lumixraku Jun 27, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat(sheets-ui): optimize ref-range for hyper-link and thread-comment (
…#2405)

* feat: update

* feat: optimize ref-range

* feat: ref-range optimize for comment

* feat: update

* feat: update

* fix: number error treated as link

* feat: update scroll

* fix: format-paint

* feat: update

* fix: update

* feat: update

* feat: update

* feat: u

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: dv-render

* feat: update

* feat: style update

* feat: update

* feat: update

* feat: lint

* feat: update

* fix: build

* feat: update

* feat: update

* feat: update

* feat: update

* feat: remove comments

* feat: update link popup

* feat: dispose popup
  • Loading branch information
weird94 authored and lumixraku committed Jun 19, 2024
commit 69acd64242faa576791e163fce8af8f405557e55
41 changes: 12 additions & 29 deletions examples/src/data/sheets/demo/default-workbook-data-demo.ts
Original file line number Diff line number Diff line change
Expand Up @@ -178,30 +178,13 @@ const dataValidation = [
const dv2 = [
{
uid: 'xxx-2',
type: 'checkbox',
ranges: [
{
startRow: 1,
endRow: 2,
startColumn: 1,
endColumn: 2,
},
],
},
{
uid: 'adN9-O',
type: 'list',
formula1: "='sheet-0005'!F4:F8",
ranges: [
{
startRow: 4,
startColumn: 5,
endRow: 14,
endColumn: 8,
rangeType: 0,
},
],
formula2: '',
type: DataValidationType.CHECKBOX,
ranges: [{
startRow: 1,
endRow: 2,
startColumn: 1,
endColumn: 2,
}],
},
];

Expand Down Expand Up @@ -23681,7 +23664,7 @@ export const DEFAULT_WORKBOOK_DATA_DEMO: IWorkbookData = {
ref: 'C6',
personId: 'mockId',
unitId: 'workbook-01',
subUnitId: 'dv-test',
subUnitId: 'sheet-0011',
},
{
text: {
Expand All @@ -23696,7 +23679,7 @@ export const DEFAULT_WORKBOOK_DATA_DEMO: IWorkbookData = {
ref: 'B6',
personId: 'mockId',
unitId: 'workbook-01',
subUnitId: 'dv-test',
subUnitId: 'sheet-0011',
},
{
text: {
Expand All @@ -23711,7 +23694,7 @@ export const DEFAULT_WORKBOOK_DATA_DEMO: IWorkbookData = {
ref: 'B7',
personId: 'mockId',
unitId: 'workbook-01',
subUnitId: 'dv-test',
subUnitId: 'sheet-0011',
},
{
text: {
Expand All @@ -23726,7 +23709,7 @@ export const DEFAULT_WORKBOOK_DATA_DEMO: IWorkbookData = {
ref: 'B8',
personId: 'mockId',
unitId: 'workbook-01',
subUnitId: 'dv-test',
subUnitId: 'sheet-0011',
},
{
text: {
Expand All @@ -23741,7 +23724,7 @@ export const DEFAULT_WORKBOOK_DATA_DEMO: IWorkbookData = {
ref: 'B9',
personId: 'mockId',
unitId: 'workbook-01',
subUnitId: 'dv-test',
subUnitId: 'sheet-0011',
},
],
}),
Expand Down
3 changes: 3 additions & 0 deletions packages/sheets-hyper-link/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,9 @@
"@univerjs/sheets-hyper-link": "workspace:*",
"@wendellhu/redi": "0.15.4",
"rxjs": ">=7.0.0"
},
"dependencies": {

},
"devDependencies": {
"@univerjs/core": "workspace:*",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ export interface IApplyFormatPainterCommandParams {
export const ApplyFormatPainterCommand: ICommand = {
type: CommandType.COMMAND,
id: 'sheet.command.apply-format-painter',
// eslint-disable-next-line max-lines-per-function
handler: async (accessor: IAccessor, params: IApplyFormatPainterCommandParams) => {
const formatPainterService = accessor.get(IFormatPainterService);
return formatPainterService.applyFormatPainter(params.unitId, params.subUnitId, params.range);
Expand Down
46 changes: 46 additions & 0 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.