Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add mobile selection #2559

Closed
wants to merge 26 commits into from
Closed

feat: add mobile selection #2559

wants to merge 26 commits into from

Conversation

lumixraku
Copy link
Contributor

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

wzhudev and others added 18 commits June 7, 2024 10:40
@wzhudev
feat: init basic mobile features
91797ec
@wzhudev
fix: rollback desktop changes
9719d1f
@wzhudev
feat: demonstrate removing canvas features
a0702ce
@wzhudev
feat: enable filter rendering
afd0598
@wzhudev
feat: support formula over web worker
12a3d7f
@wzhudev
feat: add mobile header
a137899
@wzhudev
feat: enable data validation
19be9fd
@wzhudev
feat: enable conditional formatting
c26bff6
@wzhudev
feat: add mobile worksheet
bce2a36
@wzhudev
feat: add mobile jsdoc
2d92507
@wzhudev
feat: add scroll into view
0433526
@wzhudev
feat: mobile context menu
23863ca
@wzhudev
fix: change header style
0cf29f5
@wzhudev
feat: context menu ui
fb772fd
@wzhudev
chore: code style
cda2931
@wzhudev
docs: update render unit drawing
256d5c1
@wzhudev
Merge remote-tracking branch 'origin/dev' into feat/mobile-poc
617c03c
@weird94 @lumixraku
feat(sheets-ui): optimize ref-range for hyper-link and thread-comment (…
69acd64 
…#2405)

* feat: update

* feat: optimize ref-range

* feat: ref-range optimize for comment

* feat: update

* feat: update

* fix: number error treated as link

* feat: update scroll

* fix: format-paint

* feat: update

* fix: update

* feat: update

* feat: update

* feat: u

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: dv-render

* feat: update

* feat: style update

* feat: update

* feat: update

* feat: lint

* feat: update

* fix: build

* feat: update

* feat: update

* feat: update

* feat: update

* feat: remove comments

* feat: update link popup

* feat: dispose popup
@lumixraku lumixraku force-pushed the feat/scroll-mobile branch 3 times, most recently from 36c0d36 to 59453f9 Compare June 20, 2024 08:32
@lumixraku lumixraku force-pushed the feat/scroll-mobile branch 3 times, most recently from 37652d8 to bfd2703 Compare June 22, 2024 04:09
Base automatically changed from feat/mobile-poc to dev June 25, 2024 07:51
@lumixraku lumixraku force-pushed the feat/scroll-mobile branch 3 times, most recently from 7f9a5e0 to 838c007 Compare June 27, 2024 04:30
@lumixraku
feat: mobile selection
aa41b90 
feat: start new selection when pointerup

feat: rename evenrtrigger

refactor: use mobile render controller & rename some method

test: expanding selection but can not shrink?

test: fix cannot shrink

fix: can shrink!!

test: fix shrink 3

chore: use mobile-selection-shape.ts

fix: add selectionMoveEnd$ back, then fix mobile selection popup

chore: rename
@wzhudev wzhudev closed this Jul 3, 2024
@jikkai jikkai deleted the feat/scroll-mobile branch July 5, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ybzky ybzky Awaiting requested review from ybzky ybzky will be requested when the pull request is marked ready for review ybzky is a code owner

@yuhongz yuhongz Awaiting requested review from yuhongz yuhongz will be requested when the pull request is marked ready for review yuhongz is a code owner

@Gggpound Gggpound Awaiting requested review from Gggpound Gggpound will be requested when the pull request is marked ready for review Gggpound is a code owner

@DR-Univer DR-Univer Awaiting requested review from DR-Univer DR-Univer will be requested when the pull request is marked ready for review DR-Univer is a code owner

@Dushusir Dushusir Awaiting requested review from Dushusir Dushusir will be requested when the pull request is marked ready for review Dushusir is a code owner

@siam-ese siam-ese Awaiting requested review from siam-ese siam-ese will be requested when the pull request is marked ready for review siam-ese is a code owner

@jikkai jikkai Awaiting requested review from jikkai jikkai will be requested when the pull request is marked ready for review jikkai is a code owner

@wzhudev wzhudev Awaiting requested review from wzhudev wzhudev will be requested when the pull request is marked ready for review wzhudev is a code owner

@Jocs Jocs Awaiting requested review from Jocs Jocs will be requested when the pull request is marked ready for review Jocs is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lumixraku @wzhudev @weird94