Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sheets-ui): optimize ref-range for hyper-link and thread-comment #2405

Merged
merged 48 commits into from
Jun 7, 2024

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Jun 3, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 1.44928% with 476 lines in your changes missing coverage. Please review.

Project coverage is 27.12%. Comparing base (08df397) to head (1a3c59e).
Report is 2 commits behind head on dev.

Files Patch % Lines
...hyper-link/src/controllers/ref-range.controller.ts 0.00% 125 Missing ⚠️
...lers/sheets-thread-comment-ref-range.controller.ts 0.00% 87 Missing ⚠️
...ets-hyper-link-ui/src/views/CellLinkEdit/index.tsx 0.00% 29 Missing ⚠️
...ets-data-validation/src/widgets/dropdown-widget.ts 0.00% 27 Missing ⚠️
packages/sheets-hyper-link-ui/src/common/util.ts 0.00% 27 Missing ⚠️
packages/sheets/src/services/ref-range/util.ts 4.16% 23 Missing ⚠️
...s-data-validation/src/validators/list-validator.ts 0.00% 17 Missing ⚠️
...-hyper-link-ui/src/controllers/popup.controller.ts 0.00% 13 Missing ⚠️
...s/sheets-hyper-link/src/models/hyper-link.model.ts 0.00% 13 Missing ⚠️
...sheets-hyper-link-ui/src/services/popup.service.ts 0.00% 12 Missing ⚠️
... and 34 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2405      +/-   ##
==========================================
- Coverage   27.15%   27.12%   -0.04%     
==========================================
  Files        1650     1653       +3     
  Lines       83075    83228     +153     
  Branches    17195    17234      +39     
==========================================
+ Hits        22559    22574      +15     
- Misses      60516    60654     +138     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 3, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@weird94 weird94 requested a review from jikkai as a code owner June 5, 2024 06:49
@weird94 weird94 requested a review from lumixraku as a code owner June 6, 2024 07:42
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Jun 7, 2024
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weird94 weird94 merged commit 88f2f6d into dev Jun 7, 2024
9 checks passed
@weird94 weird94 deleted the feat/ref-range-optimize branch June 7, 2024 02:58
lumixraku pushed a commit that referenced this pull request Jun 17, 2024
…#2405)

* feat: update

* feat: optimize ref-range

* feat: ref-range optimize for comment

* feat: update

* feat: update

* fix: number error treated as link

* feat: update scroll

* fix: format-paint

* feat: update

* fix: update

* feat: update

* feat: update

* feat: u

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: dv-render

* feat: update

* feat: style update

* feat: update

* feat: update

* feat: lint

* feat: update

* fix: build

* feat: update

* feat: update

* feat: update

* feat: update

* feat: remove comments

* feat: update link popup

* feat: dispose popup
lumixraku pushed a commit that referenced this pull request Jun 19, 2024
…#2405)

* feat: update

* feat: optimize ref-range

* feat: ref-range optimize for comment

* feat: update

* feat: update

* fix: number error treated as link

* feat: update scroll

* fix: format-paint

* feat: update

* fix: update

* feat: update

* feat: update

* feat: u

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: dv-render

* feat: update

* feat: style update

* feat: update

* feat: update

* feat: lint

* feat: update

* fix: build

* feat: update

* feat: update

* feat: update

* feat: update

* feat: remove comments

* feat: update link popup

* feat: dispose popup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants