Johluo/remove migrated files #3160
Conversation
JunTaoLuo
requested review from
a team
and removed request for
Tratcher and
dougbu
| @@ -10,5 +10,3 @@ | |||
| /src/Caching/ @tratcher @anurse | |||
There was a problem hiding this comment.
we should probably hand these off too @dotnet/extensions-migration .
There was a problem hiding this comment.
@JunTaoLuo are you able to provide details as to where the source for logging & logging abstractions now live? as the master branch no longer contains the source as far as I can tell?
There was a problem hiding this comment.
There was a problem hiding this comment.
See aspnet/Announcements#411 for the full list of packages and where the code lives after this migration is complete.
There was a problem hiding this comment.
@Tratcher @anurse thanks for pointing me to the announcement and new location for the source; it may be good to also update the README.md accordingly with a more information and/or to redirect others to the new location for source; as people may still think the namespace/package relates to this repo and not the runtime repo if they have missed the announcement.
There was a problem hiding this comment.
@bradygaster how far along are you with updating the readme?
There was a problem hiding this comment.
https://github.com/aspnet/Logging still points to https://github.com/dotnet/extensions which is quite confusing now
There was a problem hiding this comment.
@poizan42 did you see the updated ReadMe in extensions?
There was a problem hiding this comment.
Yes, but the description at https://github.com/aspnet/Logging should probably still be updated to point to https://github.com/dotnet/runtime/tree/master/src/libraries/Microsoft.Extensions.Logging or something
| @@ -14,9 +14,6 @@ | |||
| <IsTestAssetProject Condition="$(RepoRelativeProjectDir.Contains('testassets'))">true</IsTestAssetProject> | |||
| <IsSampleProject Condition="$(RepoRelativeProjectDir.Contains('samples'))">true</IsSampleProject> | |||
|
|
|||
| <IsReferenceAssemblyProject>false</IsReferenceAssemblyProject> | |||
There was a problem hiding this comment.
@dotnet/aspnet-build I wanted to double check removing reference assembly related logic here. Since everything left is package only, I think we can remove all ref assemblies logic right?
| @@ -1,20 +0,0 @@ | |||
| // Licensed to the .NET Foundation under one or more agreements. | |||
There was a problem hiding this comment.
@maryamariyan I've removed all DI spec and external tests since they will be moved to runtime. If you need the source for reference you can find it in the commit history.
| @@ -73,5 +70,4 @@ | |||
|
|
|||
| <Import Project="eng\Dependencies.props" /> | |||
| <Import Project="eng\ProjectReferences.props" /> | |||
| <Import Project="eng\targets\Csharp.Refs.props" Condition="'$(IsReferenceAssemblyProject)' == 'true'" /> | |||
There was a problem hiding this comment.
Hey @JunTaoLuo why is eng/targets/Csharp.Refs.props still in this repo?
There was a problem hiding this comment.
No reason, i just forgot to remove it.
* Remove migrated packages * Remove reference assemblies and associated logic * Cleanup slns and projects * Remove sample * Fix codecheck\n\nCommit migrated from dotnet/extensions@0560d97
ghost
locked as resolved and limited conversation to collaborators
Cleaning up and addressing more parts of dotnet/aspnetcore#19254
I've looked at the samples and given my thoughts on what is valuable at dotnet/AspNetCore.Docs#17646.