Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating pieces of dotnet/extensions to dotnet/aspnetcore #19254

Closed
13 tasks done
JunTaoLuo opened this issue Feb 21, 2020 · 8 comments
Closed
13 tasks done

Migrating pieces of dotnet/extensions to dotnet/aspnetcore #19254

JunTaoLuo opened this issue Feb 21, 2020 · 8 comments
Assignees
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Done This issue has been fixed task
Milestone

Comments

@JunTaoLuo
Copy link
Contributor

JunTaoLuo commented Feb 21, 2020

I don't think I ever created an issue to track this work so I'll list out the work items below:

@JunTaoLuo JunTaoLuo added the task label Feb 21, 2020
@JunTaoLuo JunTaoLuo added this to the 5.0.0 milestone Feb 21, 2020
@JunTaoLuo JunTaoLuo self-assigned this Feb 21, 2020
@Pilchie Pilchie added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Feb 24, 2020
@dougbu dougbu added the Working label Feb 24, 2020
@JunTaoLuo JunTaoLuo changed the title Migration pieces of dotnet/extensions to dotnet/aspnetcore Migrating pieces of dotnet/extensions to dotnet/aspnetcore Feb 24, 2020
@JunTaoLuo
Copy link
Contributor Author

@anurse some of the remaining work will involve your input (such as triage and issue moving) so I'm assigning you as well.

@leus
Copy link

leus commented Mar 10, 2020

Sorry if I'm wasting your time - I cannot find a discussion regarding this move. Is there an issue where I can find the rationale or discussion prior to this move? (I use some of the affected components in a very critical piece of infrastructure, so I wonder what's going on.) Thanks.

@analogrelay
Copy link
Contributor

analogrelay commented Mar 10, 2020

We’re getting an announcement put together shortly! This is purely about where we build/maintain the code though. All the packages are continuing to ship in the same places (NuGet, for example) and same supported frameworks as before. If you have specific questions feel free to ask here for now.

@JunTaoLuo JunTaoLuo removed the Working label Mar 11, 2020
@JunTaoLuo
Copy link
Contributor Author

The announcement has been posted.

@smashedapples20
Copy link

Where is the announcement? Do you have a link?

@analogrelay
Copy link
Contributor

Oops! Thanks for the reminder @smashedapples20 :). We posted the announcement but didn't link it in here. It's here: aspnet/Announcements#411

@JunTaoLuo
Copy link
Contributor Author

Announcement for breaking changes was made in aspnet/Announcements#415.

@NullEntity
Copy link

NullEntity commented Apr 28, 2020

@JunTaoLuo I was looking for the source for Config.Binder. It's at extensions/src/Configuration/Config.Binder/ in the last released tag, then extensions/src/Configuration only has Config.NewtonsoftJson on master. It doesn't look like it got migrated going through the aspnetcore commits. It looks like some stuff may have been removed from the extensions repo that shouldn't have been.

Edit: My friend told me they got migrated to dotnet/runtime. False alarm! I was confused because this was issue linked in the commit that removed them from extensions.

@dougbu dougbu removed the Working label Jun 1, 2020
@dougbu dougbu added the Done This issue has been fixed label Jun 1, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Jul 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Done This issue has been fixed task
Projects
None yet
Development

No branches or pull requests

7 participants