Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert samples from dotnet/extensions to doc articles #17646

Open
JunTaoLuo opened this issue Apr 7, 2020 · 1 comment
Open

Convert samples from dotnet/extensions to doc articles #17646

JunTaoLuo opened this issue Apr 7, 2020 · 1 comment
Labels
re-Aditya @adityamandaleeka must review

Comments

@JunTaoLuo
Copy link
Contributor

JunTaoLuo commented Apr 7, 2020

We are removing samples from dotnet/extensions. In case we want to convert any of them to samples in our docs, we can find the source in the commit history: https://github.com/dotnet/extensions/tree/75759edc975749e1a8c4198c0078755a1822eac8.

After looking through them, here's my take on whether they would be valuable:

Sample Valuable? Notes
MemoryCacheConcurencySample no Seems to just illustrate mem cache can handle concurrency.
MemoryCacheFileWatchSample no The sample illustrate using IChangeToken from a file provider in a memory cache a file provider. Suspect API docs should be sufficient
MemoryCacheSample no All basic mem cache functionalities are already documented.
ProfilingSample no This is a terrible sample, even for illustrating profiling.
SqlServerCacheConcurencySample no Seems to just illustrate SqlServer cache can handle concurrency.
RedisCacheSample no Basic usage of Redis cache is covered in docs.
SqlServerCacheSample no Basic usage of SqlServer cache is covered in docs.
Logging/SampleApp no Basic usage of Logging is covered in docs.
HttpClientFactorySample yes We don't seem to have a lot of documentation regarding Polly integration, this sample could be valuable when writing a doc on this topic.
GenericHostSample marginal Seems like all concepts are covered by our docs at: https://docs.microsoft.com/en-us/aspnet/core/fundamentals/host/generic-host?view=aspnetcore-3.1. However, there may be a few scenarios that are not explicitly illustrated in our docs such as externally controlled or windows service based generic host apps.
SampleMsmqHost marginal Though this is a more elaborate sample of generic host usage and illustrates the use of Msmq, it doesn't present any scenario that isn't covered by our docs.
@JunTaoLuo
Copy link
Contributor Author

FYI @anurse @dotnet/extensions-migration

@Rick-Anderson Rick-Anderson added the re-Aditya @adityamandaleeka must review label Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
re-Aditya @adityamandaleeka must review
Projects
None yet
Development

No branches or pull requests

3 participants