Update CPD after extensions migration #20627
Conversation
JunTaoLuo
added
the
area-infrastructure
eng/Version.Details.xml
Outdated
| @@ -273,23 +273,23 @@ | |||
| <Uri>https://github.com/dotnet/runtime</Uri> | |||
| <Sha>59ca590949ade88c712e4ca8c6835acd0e9cbf46</Sha> | |||
| </Dependency> | |||
| <Dependency Name="Microsoft.Extensions.DependencyModel" Version="5.0.0-preview.4.20205.13" CoherentParentDependency="Microsoft.Extensions.Logging"> | |||
| <Dependency Name="Microsoft.Extensions.DependencyModel" Version="5.0.0-preview.4.20205.13" CoherentParentDependency="Microsoft.NETCore.App.Runtime.win-x64"> | |||
There was a problem hiding this comment.
Actually should these be changed to Razor instead?
There was a problem hiding this comment.
If we have a direct subscription on dotnet/runtime, no. If it's still runtime -> tooling -> AspNetCore, then yes
There was a problem hiding this comment.
We should definitely not depend directly on dotnet/runtime. We hit problems almost every time the repo gets a newer runtime than what tooling built against.
There was a problem hiding this comment.
Right, I brain-farted and forgot we haven't done Tooling's consolidation yet. Yes, everything should be CPD'd thru AspNetCore-Tooling
There was a problem hiding this comment.
Okay, that's what I thought but I saw a bunch of CPDs in this file are set to NETCore.App for some reason and suspected we might have had a reason for it.
There was a problem hiding this comment.
Reason was history and this PR reflects the need to fix it up. Note as well that extensions, aspnetcore-tooling, ef6, efcore and extensions (anything that depends on dotnet/runtime packages) shouldn't need CPD at all in their 'master' branches -- assuming we're done taking anything through extensions.
|
Is this PR hitting TLS1.2 issues? |
|
Yea |
|
Actually, I'm not sure about it, the error signature looks a bit different. |
|
Actually yes, it is a related issue. Looks like they change the script to use TLS 1.2 but the agents can't use it. The discussion is at https://teams.microsoft.com/l/message/19:[email protected]/1586294254384?tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47&groupId=4d73664c-9f2f-450d-82a5-c2f02756606d&parentMessageId=1586294254384&teamName=.NET%20Core%20Eng%20Services%20Partners&channelName=First%20Responders&createdTime=1586294254384 |
Part of #19254. I'm going through our darc subscriptions to ensure everything is correct.