Ingest extensions packages from dotnet/runtime #3091
Conversation
|
Looks like we also need to update the SLN. Thanks for giving this sample, @JunTaoLuo. This gives us the recipe to follow. |
|
Ah yes, pesky codecheck. |
e7b08c9
to
14cbfa0
Compare
14cbfa0
to
00176de
Compare
|
I rebased @JunTaoLuo 's commits on latest master. |
|
As per aspnet/Announcements#411, we are currently migrating components from this repository to other repositories (dotnet/runtime, dotnet/aspnetcore). We recommend waiting until that process is complete and opening your PR against the appropriate repository. See the original announcement for a list mapping packages to the new repository. |
|
Thanks for removing them from Solution @JunTaoLuo :) |
|
@maryamariyan shouldn't extensions.options be removed as well? Also, it seems like there are functional tests left over that should probably be moved to dotnet/runtime instead. For example, Configuration.FunctionalTests and Hosting.FunctionalTests. |
|
I was being conservative with moving tests out. but yes. I'll push up a commit for those next. You're right I missed Options deletion. I'll push up a commit for that. |
|
Keeps Logging.Testing and DI.Specification even though they have dupes in runtime repo.
Another note. We're removing perf tests here for Primitives, DI, Http, and Logging.
One more item:
|
|
There are some merge conflicts between this branch and master, can you resolve them @maryamariyan or would you like help? |
|
sure thing. I'll fix them |
5f4a44a
to
dc31474
Compare
|
Changes look good, looks like SLN needs some more cleanup. |
...on/Config.NewtonsoftJson/test/Microsoft.Extensions.Configuration.NewtonsoftJson.Tests.csproj
Show resolved
Hide resolved
...on/Config.NewtonsoftJson/test/Microsoft.Extensions.Configuration.NewtonsoftJson.Tests.csproj
Outdated
Show resolved
Hide resolved
|
I can't approve my own PR but LGTM |
|
I dont have permission to merge :) |
|
@dotnet/aspnet-build Care to review so I can merge? |
| <Compile Include="..\..\Config\test\ConfigurationProviderTestBase.cs"> | ||
| <Link>test\ConfigurationProviderTestBase.cs</Link> | ||
| </Compile> | ||
| <Compile Include="..\..\Config\testassets\Test.Common\ConfigurationProviderExtensions.cs"> |
There was a problem hiding this comment.
Again, please move these out of testassets/ since they're now used as shared source
There was a problem hiding this comment.
I have a feeling we'll be cleaning up a bunch of these things in a follow-up especially since I'll be removing a bunch of the shared sources that's already been duplicated in aspnetcore as well. I wouldn't block this PR on this.
There was a problem hiding this comment.
FYI I added an item to dotnet/aspnetcore#19254 to make sure this isn't lost.
* Ingest primitives from dotnet/runtime
* Remove primitives project from sln
* using extensions libraries from runtime repo next commit deletes files
* deleting files
* Remove references from sln
* Removes
- Options
- Perf: DI, Http, and Logging
* Removes
- Config.FunctionalTests
- Hosting/IntegrationTesting
- Hosting.FunctionalTests
- Hosting.TestApp
- Logging tests
(Keeping Logging.Testing and DI.Specification eventhough dupes in runtime repo)
* Rename property
* Clean up sln file
* coorrect Automated PropertyGroup
* Also update other sln files
* nit cleanup
* move common files into one place
Co-authored-by: Maryam Ariyan <[email protected]>\n\nCommit migrated from dotnet/extensions@c2cca85
@ericstj @maryamariyan Here's a draft PR that illustrate what ingesting packages from dotnet/runtime would look like. It would look similar in dotnet/aspnetcore as well.
FYI for all those who aren't familiar with the overall plan, I don't think we'll be merging this change since we decided not to do this piecemeal and wait for all packages to be brought up in dotnet/runtime.