Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mann result #86

Merged
merged 3 commits into from
Jul 4, 2022
Merged

Update mann result #86

merged 3 commits into from
Jul 4, 2022

Conversation

dongminlee94
Copy link
Owner

PR Description

Test

Related Issues

Anything Else? (Optional) Optional section (e.g., code usage, experimental results, TODO)

//: # (If there are any other things (e.g., code usage, experimental results, TODO), please explain them.)

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added the size/XS too small size label Jul 3, 2022
@dongminlee94 dongminlee94 changed the title Update hp of mann Update mann result Jul 3, 2022
@dongminlee94 dongminlee94 changed the title Update mann result [WIP] Update mann result Jul 3, 2022
@github-actions github-actions bot added the enh Enhancement label Jul 3, 2022
@github-actions github-actions bot added size/L big size and removed size/XS too small size labels Jul 3, 2022
@dongminlee94 dongminlee94 marked this pull request as ready for review July 3, 2022 22:44
@dongminlee94 dongminlee94 changed the title [WIP] Update mann result Update mann result Jul 3, 2022
Copy link
Collaborator

@Clyde21c Clyde21c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 고생하셨습니다

@dongminlee94
Copy link
Owner Author

@all-contributors please add @LunaJang for code

@allcontributors
Copy link
Contributor

@dongminlee94

I've put up a pull request to add @LunaJang! 🎉

@Clyde21c
Copy link
Collaborator

Clyde21c commented Jul 4, 2022

@all-contributors please add @seungjaeryanlee for code

@allcontributors
Copy link
Contributor

@Clyde21c

I've put up a pull request to add @seungjaeryanlee! 🎉

@dongminlee94 dongminlee94 merged commit d4312c7 into main Jul 4, 2022
@dongminlee94 dongminlee94 deleted the enhance/update-mann-result branch July 4, 2022 10:12
Clyde21c added a commit that referenced this pull request Jul 10, 2022
* enhance/convert-eng-into-kor (#83)

* ..

* ..

* ..

* ..

* ...

* ..

* ...

* ..

* ..

* ..

* ...

* ...

* ..

Co-authored-by: Seunghyun Lee <[email protected]>

* enhance/update-readme (#84)

* ..

* ..

* hotfix/type (#85)

.

* docs: add LunaJang as a contributor for code (#87)

* docs: update README.md [skip ci]

* docs: update .all-contributorsrc [skip ci]

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

* docs: add seungjaeryanlee as a contributor for code (#88)

* docs: update README.md [skip ci]

* docs: update .all-contributorsrc [skip ci]

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

* Update mann result (#86)

* Update hp of mann

* .

* .

* Update LICENSE.md (#90)

* Create LICENSE.md

* .

* update codes up-to-date

* eng readme

* Update readme

* .

Co-authored-by: Dongmin Lee <[email protected]>
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enh Enhancement size/L big size
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants