Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance/update-readme #84

Merged
merged 2 commits into from
Jun 29, 2022
Merged

enhance/update-readme #84

merged 2 commits into from
Jun 29, 2022

Conversation

dongminlee94
Copy link
Owner

PR Description

Test

Related Issues

Anything Else? (Optional) Optional section (e.g., code usage, experimental results, TODO)

//: # (If there are any other things (e.g., code usage, experimental results, TODO), please explain them.)

@Clyde21c
Copy link
Collaborator

Clyde21c commented Jun 29, 2022

sl쪽 코드 작업해주신 분들도 contributor에 넣으면 어떨까요? star가 늘기 시작하고 나중에 커뮤니티에 공개했을때 생각하니까 문득 생각이 드네요

Copy link
Collaborator

@Clyde21c Clyde21c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다.

Copy link
Collaborator

@Clyde21c Clyde21c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added size/S small size enh Enhancement labels Jun 29, 2022
@dongminlee94
Copy link
Owner Author

sl쪽 코드 작업해주신 분들도 contributor에 넣으면 어떨까요? star가 늘기 시작하고 나중에 커뮤니티에 공개했을때 생각하니까 문득 생각이 드네요

@Clyde21c 네 좋습니다. 누구누구인가요?

@dongminlee94 dongminlee94 merged commit 4b065f6 into main Jun 29, 2022
@dongminlee94 dongminlee94 deleted the enhance/update-readme branch June 29, 2022 16:04
Clyde21c added a commit that referenced this pull request Jul 10, 2022
* enhance/convert-eng-into-kor (#83)

* ..

* ..

* ..

* ..

* ...

* ..

* ...

* ..

* ..

* ..

* ...

* ...

* ..

Co-authored-by: Seunghyun Lee <[email protected]>

* enhance/update-readme (#84)

* ..

* ..

* hotfix/type (#85)

.

* docs: add LunaJang as a contributor for code (#87)

* docs: update README.md [skip ci]

* docs: update .all-contributorsrc [skip ci]

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

* docs: add seungjaeryanlee as a contributor for code (#88)

* docs: update README.md [skip ci]

* docs: update .all-contributorsrc [skip ci]

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

* Update mann result (#86)

* Update hp of mann

* .

* .

* Update LICENSE.md (#90)

* Create LICENSE.md

* .

* update codes up-to-date

* eng readme

* Update readme

* .

Co-authored-by: Dongmin Lee <[email protected]>
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enh Enhancement size/S small size
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants