Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance/convert-eng-into-kor #83

Merged
merged 13 commits into from
Jun 28, 2022
Merged

Conversation

dongminlee94
Copy link
Owner

PR Description

Test

Related Issues

Anything Else? (Optional) Optional section (e.g., code usage, experimental results, TODO)

//: # (If there are any other things (e.g., code usage, experimental results, TODO), please explain them.)

@github-actions github-actions bot requested a review from Clyde21c June 26, 2022 01:36
@github-actions github-actions bot added size/L big size enh Enhancement labels Jun 26, 2022
@github-actions github-actions bot added size/XL too big size and removed size/L big size labels Jun 26, 2022
@Clyde21c Clyde21c force-pushed the enhance/convert-eng-into-kor branch from e4b4421 to 6dc30f2 Compare June 26, 2022 05:23
@github-actions github-actions bot added size/L big size size/XL too big size and removed size/XL too big size size/L big size labels Jun 26, 2022
@Clyde21c Clyde21c force-pushed the enhance/convert-eng-into-kor branch from 85a27ea to 6dc30f2 Compare June 26, 2022 05:42
@github-actions github-actions bot added size/L big size and removed size/XL too big size labels Jun 26, 2022
@github-actions github-actions bot added size/XXL toooooo big size and removed size/L big size labels Jun 26, 2022
Copy link
Collaborator

@Clyde21c Clyde21c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

주석 한글화 완료. LGTM

Copy link
Collaborator

@Clyde21c Clyde21c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dongminlee94 dongminlee94 merged commit 314eb18 into main Jun 28, 2022
@dongminlee94 dongminlee94 deleted the enhance/convert-eng-into-kor branch June 28, 2022 14:40
Clyde21c added a commit that referenced this pull request Jul 10, 2022
* enhance/convert-eng-into-kor (#83)

* ..

* ..

* ..

* ..

* ...

* ..

* ...

* ..

* ..

* ..

* ...

* ...

* ..

Co-authored-by: Seunghyun Lee <[email protected]>

* enhance/update-readme (#84)

* ..

* ..

* hotfix/type (#85)

.

* docs: add LunaJang as a contributor for code (#87)

* docs: update README.md [skip ci]

* docs: update .all-contributorsrc [skip ci]

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

* docs: add seungjaeryanlee as a contributor for code (#88)

* docs: update README.md [skip ci]

* docs: update .all-contributorsrc [skip ci]

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

* Update mann result (#86)

* Update hp of mann

* .

* .

* Update LICENSE.md (#90)

* Create LICENSE.md

* .

* update codes up-to-date

* eng readme

* Update readme

* .

Co-authored-by: Dongmin Lee <[email protected]>
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enh Enhancement size/XXL toooooo big size
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants