Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add launch file with port arg #84

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Add launch file with port arg #84

merged 2 commits into from
Sep 5, 2023

Conversation

jccurtis
Copy link
Contributor

I added a launch file (ROS1) with an argument to specify the port. It is installed to the shared package dest so one can run:

roslaunch rosboard rosboard.launch port:=####

In my case this is needed to use the --wait arg to tell roslaunch to wait for roscore before starting the node.

@dheera
Copy link
Owner

dheera commented Aug 27, 2021

Hi @jccurtis thanks for this. I'd like to understand can you please elaborate on why this is useful as opposed to just rosrun rosboard rosboard_node _port:=####?

@jccurtis
Copy link
Contributor Author

Hey @dheera. Thanks for taking a look. My use case is rather specific because I have rosboard running in a docker container and waiting for a different container running roscore to spin up the roscore process. I've had much more success with roslaunch and --wait to correctly get the clock from roscore when running data from a bag with the --clock argument. I understand that rosrun will wait for roscore but it doesn't get the correct clock (or it is a race condition and will sometimes based on startup time.) I am using the launch file from our fork and I thought it might be helpful for others accustomed to launch files. I totally understand if you see this as bloat to your project. Really nice work here btw 👏

@dheera
Copy link
Owner

dheera commented Sep 5, 2023

Thank you!

@dheera dheera merged commit 83b6741 into dheera:main Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants