strict - clean ws/, io/, fs/

encoding/toml.ts

@@ -3,15 +3,14 @@ import { deepAssign } from "../util/deep_assign.ts";
 import { pad } from "../strings/pad.ts";
 
 class KeyValuePair {
- key: string;
- value: unknown;
+ constructor (public key: string, public value: unknown) {}
 }
 
 class ParserGroup {
- type: string;
- name: string;
  arrValues: unknown[] = [];
  objValues: object = {};
+
+ constructor (public type: string, public name: string) {}
 }
 
 class ParserContext {
@@ -167,22 +166,22 @@ class Parser {
  if (this.context.currentGroup) {
  this._groupToOutput();
  }
- let g = new ParserGroup();
- g.name = line.match(captureReg)[1];
- if (g.name.match(/\[.*\]/)) {
- g.type = "array";
- g.name = g.name.match(captureReg)[1];
+
+ let type;
+ let name = line.match(captureReg)![1];
+ if (name.match(/\[.*\]/)) {
+ type = "array";
+ name = name.match(captureReg)![1];
  } else {
- g.type = "object";
+ type = "object";
  }
- this.context.currentGroup = g;
+ this.context.currentGroup = new ParserGroup(type, name);
  }
  _processDeclaration(line: string): KeyValuePair {
- let kv = new KeyValuePair();
  const idx = line.indexOf("=");
- kv.key = line.substring(0, idx).trim();
- kv.value = this._parseData(line.slice(idx + 1));
- return kv;
+ const key = line.substring(0, idx).trim();
+ const value = this._parseData(line.slice(idx + 1));
+ return new KeyValuePair(key, value);
  }
  // TODO (zekth) Need refactor using ACC
  _parseData(dataString: string): unknown {

fs/path/win32.ts

@@ -171,7 +171,7 @@ export function normalize(path: string): string {
  const len = path.length;
  if (len === 0) return ".";
  let rootEnd = 0;
- let device: string;
+ let device: string | undefined;
  let isAbsolute = false;
  const code = path.charCodeAt(0);
 
@@ -301,7 +301,7 @@ export function join(...paths: string[]): string {
  const pathsCount = paths.length;
  if (pathsCount === 0) return ".";
 
- let joined: string;
+ let joined: string | undefined;
  let firstPart: string;
  for (let i = 0; i < pathsCount; ++i) {
  let path = paths[i];
@@ -329,6 +329,7 @@ export function join(...paths: string[]): string {
  // path.join('//server', 'share') -> '\\\\server\\share\\')
  let needsReplace = true;
  let slashCount = 0;
+ firstPart = firstPart!;
  if (isPathSeparator(firstPart.charCodeAt(0))) {
  ++slashCount;
  const firstLen = firstPart.length;

io/bufio.ts

@@ -25,13 +25,12 @@ export type BufState =
 
 /** BufReader implements buffering for a Reader object. */
 export class BufReader implements Reader {
- private buf: Uint8Array;
- private rd: Reader; // Reader provided by caller.
+ private buf!: Uint8Array;
+ private rd!: Reader; // Reader provided by caller.
  private r = 0; // buf read position.
  private w = 0; // buf write position.
- private lastByte: number;
- private lastCharSize: number;
- private err: BufState;
+ private lastByte!: number;
+ private err: BufState = null;
 
  /** return new BufReader unless r is BufReader */
  static create(r: Reader, size = DEFAULT_BUF_SIZE): BufReader {
@@ -282,7 +281,7 @@ export class BufReader implements Reader {
  async readSlice(delim: number): Promise<[Uint8Array, BufState]> {
  let s = 0; // search start index
  let line: Uint8Array;
- let err: BufState;
+ let err: BufState = null;
  while (true) {
  // Search buffer.
  let i = this.buf.subarray(this.r + s, this.w).indexOf(delim);
@@ -347,7 +346,7 @@ export class BufReader implements Reader {
  }
 
  // 0 <= n <= len(this.buf)
- let err: BufState;
+ let err: BufState = null;
  let avail = this.w - this.r;
  if (avail < n) {
  // not enough data in buffer
@@ -408,7 +407,7 @@ export class BufWriter implements Writer {
  return null;
  }
 
- let n: number;
+ let n: number = 0;
  let err: BufState = null;
  try {
  n = await this.wr.write(this.buf.subarray(0, this.n));
@@ -429,6 +428,7 @@ export class BufWriter implements Writer {
  return err;
  }
  this.n = 0;
+ return err;
  }
 
  /** Returns how many bytes are unused in the buffer. */
@@ -448,7 +448,7 @@ export class BufWriter implements Writer {
  */
  async write(p: Uint8Array): Promise<number> {
  let nn = 0;
- let n: number;
+ let n: number = 0;
  while (p.byteLength > this.available() && !this.err) {
  if (this.buffered() == 0) {
  // Large write, empty buffer.

ws/mod.ts

@@ -31,19 +31,19 @@ export interface WebSocketCloseEvent {
  reason?: string;
 }
 
-export function isWebSocketCloseEvent(a): a is WebSocketCloseEvent {
- return a && typeof a["code"] === "number";
+export function isWebSocketCloseEvent(a: WebSocketEvent): a is WebSocketCloseEvent {
+ return typeof a === "object" && a.hasOwnProperty("code");
 }
 
 export type WebSocketPingEvent = ["ping", Uint8Array];
 
-export function isWebSocketPingEvent(a): a is WebSocketPingEvent {
+export function isWebSocketPingEvent(a: WebSocketEvent): a is WebSocketPingEvent {
  return Array.isArray(a) && a[0] === "ping" && a[1] instanceof Uint8Array;
 }
 
 export type WebSocketPongEvent = ["pong", Uint8Array];
 
-export function isWebSocketPongEvent(a): a is WebSocketPongEvent {
+export function isWebSocketPongEvent(a: WebSocketEvent): a is WebSocketPongEvent {
  return Array.isArray(a) && a[0] === "pong" && a[1] instanceof Uint8Array;
 }
 
@@ -455,7 +455,9 @@ export async function connectWebSocket(
  if (!m) {
  abortHandshake(new Error("ws: invalid status line: " + statusLine));
  }
- const [_, version, statusCode] = m;
+ const version: string = m![1];
+ const statusCode: string = m![2];
+
  if (version !== "HTTP/1.1" || statusCode !== "101") {
  abortHandshake(
  new Error(