strict - clean http/

http/cookie_test.ts

@@ -38,7 +38,7 @@ test({
  let res: Response = {};
  delCookie(res, "deno");
  assertEquals(
- res.headers.get("Set-Cookie"),
+ res.headers!.get("Set-Cookie"),
  "deno=; Expires=Thus, 01 Jan 1970 00:00:00 GMT"
  );
  }

http/file_server_test.ts

@@ -6,7 +6,8 @@ import { assert, assertEquals } from "../testing/asserts.ts";
 import { BufReader } from "../io/bufio.ts";
 import { TextProtoReader } from "../textproto/mod.ts";
 
-let fileServer;
+let fileServer: Deno.Process;
+
 async function startFileServer(): Promise<void> {
  fileServer = run({
  args: [
@@ -21,14 +22,14 @@ async function startFileServer(): Promise<void> {
  stdout: "piped"
  });
  // Once fileServer is ready it will write to its stdout.
- const r = new TextProtoReader(new BufReader(fileServer.stdout));
+ const r = new TextProtoReader(new BufReader(fileServer.stdout!));
  const [s, err] = await r.readLine();
  assert(err == null);
  assert(s.includes("server listening"));
 }
 function killFileServer(): void {
  fileServer.close();
- fileServer.stdout.close();
+ fileServer.stdout!.close();
 }
 
 test(async function serveFile(): Promise<void> {

http/racing_server_test.ts

@@ -5,21 +5,21 @@ import { assert, assertEquals } from "../testing/asserts.ts";
 import { BufReader } from "../io/bufio.ts";
 import { TextProtoReader } from "../textproto/mod.ts";
 
-let server;
+let server: Deno.Process;
 async function startServer(): Promise<void> {
  server = run({
  args: ["deno", "run", "-A", "http/racing_server.ts"],
  stdout: "piped"
  });
  // Once fileServer is ready it will write to its stdout.
- const r = new TextProtoReader(new BufReader(server.stdout));
+ const r = new TextProtoReader(new BufReader(server.stdout!));
  const [s, err] = await r.readLine();
  assert(err == null);
  assert(s.includes("Racing server listening..."));
 }
 function killServer(): void {
  server.close();
- server.stdout.close();
+ server.stdout!.close();
 }
 
 let input = `GET / HTTP/1.1

http/server_test.ts

@@ -314,60 +314,59 @@ malformedHeader
 // https://github.com/golang/go/blob/go1.12.5/src/net/http/request_test.go#L377-L443
 // TODO(zekth) fix tests
 test(async function testReadRequestError(): Promise<void> {
- const testCases = {
- 0: {
+ const testCases = [
+ {
  in: "GET / HTTP/1.1\r\nheader: foo\r\n\r\n",
  headers: [{ key: "header", value: "foo" }],
  err: null
  },
- 1: { in: "GET / HTTP/1.1\r\nheader:foo\r\n", err: "EOF", headers: [] },
- 2: { in: "", err: "EOF", headers: [] },
- 3: {
+ { in: "GET / HTTP/1.1\r\nheader:foo\r\n", err: "EOF", headers: [] },
+ { in: "", err: "EOF", headers: [] },
+ {
  in: "HEAD / HTTP/1.1\r\nContent-Length:4\r\n\r\n",
  err: "http: method cannot contain a Content-Length"
  },
- 4: {
+ {
  in: "HEAD / HTTP/1.1\r\n\r\n",
  headers: [],
  err: null
  },
  // Multiple Content-Length values should either be
  // deduplicated if same or reject otherwise
  // See Issue 16490.
- 5: {
+ {
  in:
  "POST / HTTP/1.1\r\nContent-Length: 10\r\nContent-Length: 0\r\n\r\nGopher hey\r\n",
  err: "cannot contain multiple Content-Length headers"
  },
- 6: {
+ {
  in:
  "POST / HTTP/1.1\r\nContent-Length: 10\r\nContent-Length: 6\r\n\r\nGopher\r\n",
  err: "cannot contain multiple Content-Length headers"
  },
- 7: {
+ {
  in:
  "PUT / HTTP/1.1\r\nContent-Length: 6 \r\nContent-Length: 6\r\nContent-Length:6\r\n\r\nGopher\r\n",
  err: null,
  headers: [{ key: "Content-Length", value: "6" }]
  },
- 8: {
+ {
  in: "PUT / HTTP/1.1\r\nContent-Length: 1\r\nContent-Length: 6 \r\n\r\n",
  err: "cannot contain multiple Content-Length headers"
  },
  // Setting an empty header is swallowed by textproto
  // see: readMIMEHeader()
- // 9: {
+ // {
  // in: "POST / HTTP/1.1\r\nContent-Length:\r\nContent-Length: 3\r\n\r\n",
  // err: "cannot contain multiple Content-Length headers"
  // },
- 10: {
+ {
  in: "HEAD / HTTP/1.1\r\nContent-Length:0\r\nContent-Length: 0\r\n\r\n",
  headers: [{ key: "Content-Length", value: "0" }],
  err: null
  }
- };
- for (const p in testCases) {
- const test = testCases[p];
+ ];
+ for (const test of testCases) {
  const reader = new BufReader(new StringReader(test.in));
  let _err;
  if (test.err && test.err != "EOF") {
@@ -380,7 +379,7 @@ test(async function testReadRequestError(): Promise<void> {
  } else {
  const [req, err] = await readRequest(reader);
  assertEquals(test.err, err);
- for (const h of test.headers) {
+ for (const h of test.headers!) {
  assertEquals(req.headers.get(h.key), h.value);
  }
  }