fix(cli/module_graph): Set useDefineForClassFields to true #9774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitsonk
approved these changes
Mar 13, 2021
nayeemrmn
force-pushed
the
use-define-for-class-fields
branch
from
b7246b1
to
b9c42b4
Compare
ry
added a commit
to ry/deno
that referenced
this pull request
Mar 15, 2021
…enoland#9774)" Backwards incompatible change cannot be made in-between patch releases. This reverts commit c470983.
kitsonk
added a commit
to kitsonk/deno
that referenced
this pull request
Apr 6, 2021
kitsonk
added a commit
to kitsonk/deno
that referenced
this pull request
Apr 8, 2021
nayeemrmn
added a commit
to nayeemrmn/deno
that referenced
this pull request
Apr 10, 2021
nayeemrmn
added a commit
to nayeemrmn/deno
that referenced
this pull request
Apr 10, 2021
nayeemrmn
added a commit
to nayeemrmn/deno
that referenced
this pull request
Apr 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We decided to do this around #7148 (comment), added
"useDefineForClassFields"to the set of ignored compiler options in #7228 and documented it as set to true in #9196. Unless there was a regression, I don't think we ever actually set it to true.Fixes #9773 (the example now produces an intuitive type error).