Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reland #9774: Set useDefineForClassFields to true #10119

Merged
merged 3 commits into from
Apr 10, 2021
Merged

Reland #9774: Set useDefineForClassFields to true #10119

merged 3 commits into from
Apr 10, 2021

Conversation

nayeemrmn
Copy link
Collaborator

@nayeemrmn nayeemrmn commented Apr 10, 2021 •
edited
Loading

#9774. The option is now also passed to swc, which supports it as of recently.

kitsonk
kitsonk approved these changes Apr 10, 2021
View reviewed changes
Copy link
Contributor

@kitsonk kitsonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

IiRC, we will need to update some things in std as well it is likely to cause some breakage (good though) in the community.

@lucacasonato
Copy link
Member

std has already been adapted in denoland/std#807.

@kitsonk kitsonk added the breaking change a change or feature that breaks existing semantics label Apr 10, 2021
@kitsonk kitsonk merged commit 8aa0d5f into denoland:main Apr 10, 2021
@nayeemrmn nayeemrmn deleted the reland-9774 branch April 10, 2021 22:01
@kitsonk kitsonk mentioned this pull request Apr 20, 2021
Closed
@travismfrank travismfrank mentioned this pull request Apr 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kitsonk kitsonk kitsonk approved these changes

Assignees
No one assigned
Labels
breaking change a change or feature that breaks existing semantics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nayeemrmn @lucacasonato @kitsonk