fix(lsp): normalize windows file URLs properly

[kitsonk]

Fixes #9744
Fixes denoland/vscode_deno#386

[kitsonk]

ok, I have test this under windows and it resolves the issue...

[piscisaureus]

It's not quite clear to me what the purpose of normalizing is here. I would suppose that file:https:/// URLs would always get percent-decoded, as they are URLs after all.

So if I had written:

import "file:https:///C%2A/foo/bar/baz/file%20with%20%25%20and%20%23%20in%20the%20name.txt";

It'd import from:

C:\foo\bar\baz\file with % and # in the name.txt

[kitsonk]

@piscisaureus thanks for the feedback. I have taken a different approach, which should be far more foolproof. File URLs are transformed into file paths and then back into file URLs. This ensures that the URL will be normalized in a way that matches Rust's behaviour. I tested it again on windows and it fixes both the linked issues, but should be able to be generically applied to any client URL.

[piscisaureus]

This looks good! Would be great to have a unit test.

[kitsonk]

This looks good! Would be great to have a unit test.

There are two unit tests, one for a Windows system (which ensures the drive letter get recapitalised) and one for non-windows which deals just with percent encoding of parts of the path.

Did you mean some sort of integration test? Those are complicated in this case because of the need to write out real files, mangle them, craft the messages and then send them in and deal with the nature of windows versus non-windows.

[piscisaureus]

LGTM

[piscisaureus]

Sorry, I must have overlooked the tests that were already there.