Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change release build flags to optimize for performance #9249

Closed
wants to merge 1 commit into from

Conversation

evanwashere
Copy link
Contributor

improves perf of deno ops/core calls that are not i/o bound at the cost of release build time
haven't tested on other platforms but on macOS arm deno cli is ~900kb larger and denort is 1mb smaller

last change to opt-level #6907

@CLAassistant
Copy link

CLAassistant commented Jan 24, 2021

CLA assistant check
All committers have signed the CLA.

@bartlomieju
Copy link
Member

Looks like this change makes CI run twice as long

@evanwashere
Copy link
Contributor Author

benchmark results of this pr
benchmark results of f5c28c6

@ry
Copy link
Member

ry commented Jan 29, 2021

Hi @evanwashere, thanks for the patch but we need more analysis than this - it appears to increase build time. This patch is done to improve performance, what measurements are improving? Previously we found no measurable improvement in our benchmark suite using -O3. Happy to reopen and discuss further if you want to get into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants