Change release build flags to optimize for size #6907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piscisaureus
approved these changes
Jul 28, 2020
piscisaureus
added a commit
that referenced
this pull request
Aug 8, 2020
This reverts commit b7942bf.
piscisaureus
added a commit
to piscisaureus/deno
that referenced
this pull request
Aug 8, 2020
…" (denoland#6980) The non-default build (codegen) flags are applied only when building the binary, however they are not used when building the tests. This makes cargo recompile all crate dependencies and effectively doubles the time to build and test in release mode. Additionally when we were "watching" the benchmarks, this was likely a meaningless activity as they too could have been built without these alternative flags. This reverts commit b7942bf.
piscisaureus
added a commit
to piscisaureus/deno
that referenced
this pull request
Aug 8, 2020
…" (denoland#6980) The non-default build (codegen) flags are applied only when building the binary, however they are not used when building the tests. This makes cargo recompile all crate dependencies and effectively doubles the time to build and test in release mode. Additionally when we were "watching" the benchmarks, this was likely a meaningless activity as they too could have been built without these alternative flags. This reverts commit b7942bf.
piscisaureus
added a commit
that referenced
this pull request
Aug 8, 2020
The non-default build (codegen) flags are applied only when building the binary, however they are not used when building the tests. This makes cargo recompile all crate dependencies and effectively doubles the time to build and test in release mode. Additionally when we were "watching" the benchmarks, this was likely a meaningless activity as they too could have been built without these alternative flags. This reverts commit b7942bf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This decreases binary size by about 11% and also speeds up built-time for release builds (due to
codegen-units = 1).I want to land this and see what the effects on the benchmarks are. Because V8 is compiled separately, and is generally the bottleneck, it's possible this change will not effect the benchmarks much.
I got these tips from https://github.com/johnthagen/min-sized-rust