Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change release build flags to -O3 when favorable #9538

Merged
merged 3 commits into from
Feb 18, 2021
Merged

Change release build flags to -O3 when favorable #9538

merged 3 commits into from
Feb 18, 2021

Conversation

evanwashere
Copy link
Contributor

@evanwashere evanwashere commented Feb 18, 2021 •
edited
Loading

Continuation of #9249 that focuses on compiling only cpu bound packages with -O3

more packages to consider for -O3:

  • hashing and crypto libraries used by WebCrypto
  • rustls (and its deps) note: could potentially blow size & compile time trough roof

some benchmarks

rand
fetch with compression
fetch compressed

@bartlomieju bartlomieju requested a review from ry February 18, 2021 13:54
@evanwashere
Copy link
Contributor Author

build time is practically unaffected

from ubuntu bench

bin old new
deno 66.353mb 66.353mb
denort 47.209mb 47.198mb

ry
ry approved these changes Feb 18, 2021
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evanwashere Thank you for patch and complete analysis. LGTM.

@ry ry merged commit c0f10e7 into denoland:master Feb 18, 2021
@evanwashere evanwashere deleted the opt-level-3 branch February 18, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@evanwashere @ry